1854461 - [meta] Investigate elements that are failing Tier 2 a11y_checks for Webextensions

Status: NEW

(WebExtensions :: Frontend, task, P3)

Description

[Anna Yeddi [:ayeddi]]

We are working on enabling Tier 2 a11y-checks to ensure our products have basic accessibility built-in (bug 1692110) and before that, we need to prepare the existing code base. While we triage and investigate existent tests that would fail once the a11y-checks are enabled in the CI, the failing tests were failed-if by the bug 1854460.

This task is to track the investigation into the reasons each of these tests failed and to be able to backtrack these tests once they're resolved.

Individual bugs to block the following bugs

1. (all) this meta bug
2. (Interactive elements must be labeled / Node is enabled but disabled via the accessibility API) bug 1854227 (a11y_checks_labeled)
3. (Node is not accessible via accessibility API / Node is not focusable via the accessibility API / Node is enabled but disabled via the accessibility API) Bug 1848394 (a11y_checks_focusable)

Tests affected:

FAIL	browser/components/extensions/test/browser/browser_ext_browserAction_disabled.js	Node is enabled but disabled via the accessibility API	_afdfcbb6-9280-4990-99ed-890b387d6ee4_-BAP	toolbarbutton	unified-extensions-item-action-button toolbarbutton-1 panel-no-padding webextension-browser-action
FAIL	browser/components/extensions/test/browser/browser_ext_browserAction_disabled.js	Node is not focusable via the accessibility API	_afdfcbb6-9280-4990-99ed-890b387d6ee4_-BAP	toolbarbutton	unified-extensions-item-action-button panel-no-padding webextension-browser-action subviewbutton subviewbutton-iconic
FAIL	browser/components/extensions/test/browser/browser_ext_browserAction_disabled.js	Node is enabled but disabled via the accessibility API	_afdfcbb6-9280-4990-99ed-890b387d6ee4_-BAP	toolbarbutton	unified-extensions-item-action-button panel-no-padding webextension-browser-action subviewbutton subviewbutton-iconic
FAIL	browser/components/extensions/test/browser/browser_ext_browserAction_popup_preload.js	Node is not accessible via accessibility API		html:body	
FAIL	browser/components/extensions/test/browser/browser_ext_browserAction_popup_preload.js	Node is enabled but disabled via the accessibility API	_2ede3b3d-5821-4f4d-b1e3-7c4cee52bc0e_-BAP	toolbarbutton	unified-extensions-item-action-button toolbarbutton-1 panel-no-padding webextension-browser-action
FAIL	browser/components/extensions/test/browser/browser_ext_menus_capture_secondary_click.js	Node is not focusable via the accessibility API	_78f1afd6-9059-4e04-a114-6f8c35bbdb79_-menuitem-94	menuitem	
FAIL	browser/components/extensions/test/browser/browser_ext_menus_capture_secondary_click.js	Node is enabled but disabled via the accessibility API	_78f1afd6-9059-4e04-a114-6f8c35bbdb79_-menuitem-94	menuitem	
FAIL	browser/components/extensions/test/browser/browser_unified_extensions.js	Node is not accessible via accessibility API		browser	

Jobs affected:

1. test-linux1804-64-qr/opt-mochitest-browser-chrome-swr-a11y-checks-${1-7} (Try run)

---

Some Tier 2 accessibility checks for click events fired on controls that should be keyboard accessible and have valid labels were failing for this component. They were captured by testing/mochitest/tests/SimpleTest/AccessibilityUtils.js via bug 1692110. These failing tests should be temporarily skipped in the directory's browser.ini file while we investigate these failures. For all confirmed bugs individual defects should be filed.

When the individual test failures are resolved and the individual bugs are closed, remove the fail-if condition for a11y_checks from the appropriate files/sections to ensure better test coverage and to avoid regressions in a11y of these components.