1854462 - [wpt-sync] Sync PR 42003 - Fix 'currentcolor' handling for drop-shadow(...) filter functions

Status: RESOLVED FIXED

(Core :: Web Painting, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 42003 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/42003
Details from upstream follow.

Fredrik Söderquist <[e-mail]> wrote:

Fix 'currentcolor' handling for drop-shadow(...) filter functions

For drop-shadow(), the 'currentcolor' keyword was resolved at style
resolution time by FilterOperationResolver. This means that it was baked
into style, and couldn't respond to a change in color.

Instead preserve the keyword in the FilterOperation and let the
FilterEffectBuilder resolve the color if needed. Add infrastructure to
FilterOperation/s to determine if a filter chain depends on
'currentcolor' to allow invalidation of the filter chain when the color
changes.

Bug: 1469327
Change-Id: I81bd0324637f1c1111add5d74c58418f205c3c77
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4863914
Reviewed-by: Xianzhu Wang \<[e-mail]>
Commit-Queue: Fredrik Söderquist \<[e-mail]>
Reviewed-by: Fernando Serboncini \<[e-mail]>
Cr-Commit-Position: refs/heads/main@{#1199067}

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=891d300d9a32c5a8097feb54a3d2970ee41142b2

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 9 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests

Status Summary

Firefox

PASS: 1

Chrome

FAIL: 1

Safari

FAIL: 1

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/mozilla-central/rev/3854d2b7978d
[wpt PR 42003] - Fix 'currentcolor' handling for drop-shadow(...) filter functions, a=testonly

Comment 4

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/3854d2b7978d