pr_PredictNextNotifyTime in pralarm.c always returns 0 instead of delta time interval

RESOLVED FIXED in 4.3

Status

NSPR
NSPR
--
trivial
RESOLVED FIXED
16 years ago
15 years ago

People

(Reporter: Peter Klavins, Assigned: Wan-Teh Chang)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Reporter)

Description

16 years ago
User-Agent:       Mozilla/4.0 (compatible; MSIE 6.0; Windows NT 5.1; .NET CLR 1.0.3705)
Build Identifier: 

A change source code inspection of pr_PredictNextNotifyTime in pralarm.c 
revealed that the assignment to delta at the end of the function 
was 'nextnotify - nextnotify', always yielding 0, instead of 'nextnotify - 
lastnotify', yielding the time interval between the next and last notifies. 
The source code line

    delta = id->nextNotify - id->nextNotify;

should become

    delta = id->nextNotify - id->lastNotify;


Reproducible: Always

Steps to Reproduce:
1.
2.
3.



Expected Results:  
See bug details
(Assignee)

Comment 1

16 years ago
You are right.  That is a bug.  Fortunately we never
use the return value of pr_PredictNextNotifyTime.

I've checked in the fix you suggested.  Thank you.
Severity: normal → trivial
Status: UNCONFIRMED → RESOLVED
Last Resolved: 16 years ago
Resolution: --- → FIXED
Target Milestone: --- → 4.3
(Reporter)

Comment 2

15 years ago
lkjhkjh
(Reporter)

Comment 3

15 years ago
I apologize for wasting your time reading these additional comments -- I 
accidentally pressed 'Commit' while reading the bug
You need to log in before you can comment on or make changes to this bug.