Closed
Bug 1854631
Opened 2 years ago
Closed 2 years ago
Refactor ReviewQualityCheckInfoCard to simplify API
Categories
(Firefox for Android Graveyard :: Shopping, task, P2)
Tracking
(firefox117 disabled, firefox118 disabled, firefox119 fixed)
RESOLVED
FIXED
119 Branch
People
(Reporter: rsainani, Assigned: rsainani)
References
Details
(Whiteboard: [fxdroid] [fakespot-android-mvp])
Attachments
(1 file)
– Use LinkTextState and InfoButtonText to encapsulate text and actions that belong together, removing the need for empty string default params.
– Use type as an identifier for the icon to display.
– Use common ReviewQualityCheckCard to reuse the shape and other properties.
|
Assignee | |
Updated•2 years ago
|
Assignee: nobody → rsainani
Status: NEW → ASSIGNED
status-firefox117:
--- → disabled
status-firefox118:
--- → disabled
status-firefox119:
--- → disabled
Priority: -- → P2
|
|
Assignee | |
Updated•2 years ago
|
Blocks: fenix-fakespot-integration
Whiteboard: [fxdroid] [fakespot-android-mvp]
|
||
Updated•2 years ago
|
|
||
Comment 1•2 years ago
|
||
|
|
||
Comment 2•2 years ago
|
||
Authored by https://github.com/rahulsainani
https://github.com/mozilla-mobile/firefox-android/commit/4cfa3942fff8842388d6b5c24ca0f9875e1a86d5
[main] Bug 1854631 - Refactor review checker info card
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Flags: qe-verify+
Resolution: --- → FIXED
Target Milestone: --- → 119 Branch
|
|
Assignee | |
Updated•2 years ago
|
Flags: qe-verify+
|
||
Updated•9 months ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•