185467 - [FIXr]<hr>-tags are displayed dotted on pages that contain image-maps

Status: RESOLVED FIXED

(Core Graveyard :: GFX, defect, P2)

Description

[Jan Darmochwal]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.3a) Gecko/20021212
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.3a) Gecko/20021212

On pages that contain image-maps horizontal lines (<hr>-tag) are dotted. On
other pages these lines are solid.
When selecting the dotted lines or scrolling them out of view and then back
again they become solid.

Reproducible: Always

Steps to Reproduce:
1. go to a page containing <hr>-tags and image-maps (I will add a testcase)
Actual Results:  
The horizontal lines are dotted.

Expected Results:  
The horizontal lines should be solid.

Comment 1

[Jan Darmochwal]

Attachment: testcase

Comment 2

[Bill Mason]

WFM 2002121308 PC/Win98.
A Linux-only issue?

Comment 3

[Boris Zbarsky [:bzbarsky]]

if repainting changes it, it's not layout....

Comment 4

[Kai Lahmann (is there, where MNG is)]

wfm - which display driver?

Comment 5

[R.K.Aa.]

Confirming. I see this too, current trunk CVS, Linux. Use xmag to see it.
To the naked eye the lines may only appear as slightly greyer than usual.

Comment 6

[R.K.Aa.]

Attachment: screenshot of xmag window

screenshot of an xmag window with a snap of some hr's that have been partly
covered by another window. They covered areas appear as whole lines when
uncovered again.

Comment 7

[Robert C. Sheets]

Reproducible here using both debian's 1.2.1-3 and linux nightly build 2002121404
on debian sid (i386).

Comment 8

[Robert C. Sheets]

After making a few changes to the testcase, I've found that a HR placed
immediately before the image map stays dotted even if you cause it to be redrawn
(by selecting it, moving another window over it, etc.); also, if you select a
group of HRs, they're redrawn correctly, but if you select a group of HRs
including an HR that is immediately before the image map, *none* of them are
correctly redrawn.

Comment 9

[R.K.Aa.]

3 people can reproduce, and i can't find a dup: Resolving as New.
I use nVidia driver 1.0-3123

Comment 10

[Bruce Davidson]

This is WFM on a recent nightly (2003081304) on Win2k. As the reported problems
seem to be Linux specific can someone ruuning Linxu please check it again
following the checkin of fixes to bug 38370. (You'll need a trunk build from 1st
August 2003 or later). That bug fixed numerous problems with <hr> elements,
though as noted in comment #3 not clear this is/was ever a layout problem.

Comment 11

[Jan Darmochwal]

Attachment: tiny patch

removing this line:
   aRenderingContext.SetLineStyle(nsLineStyle_kDotted);
in layout/generic/nsImageFrame.cpp solves this bug

Comment 12

[Boris Zbarsky [:bzbarsky]]

Jan, nice catch!  That's not quite the right fix, though....

Comment 13

[Boris Zbarsky [:bzbarsky]]

Attachment: Pop off the style and color change too

Comment 14

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 179960 [details] [diff] [review]
Pop off the style and color change too

Could this please be approved for 1.8b2?  It's a very safe fix that makes us
not screw up all solid lines (borders, hr, etc) on pages with imagemaps...

Comment 15

[Asa Dotzler [:asa]]

Comment on attachment 179960 [details] [diff] [review]
Pop off the style and color change too

a=asa

Comment 16

[Boris Zbarsky [:bzbarsky]]

Fixed.  Jan, thank you again for locating the buggy code.

Comment 17

[Boris Zbarsky [:bzbarsky]]

*** Bug 203079 has been marked as a duplicate of this bug. ***

Comment 18

[Boris Zbarsky [:bzbarsky]]

*** Bug 293133 has been marked as a duplicate of this bug. ***

Comment 19

[zug_treno]

*** Bug 327324 has been marked as a duplicate of this bug. ***