1854729 - [wpt-sync] Sync PR 42032 - scroll-to: Improve handling for invalid percent encoding

Status: RESOLVED FIXED

(Testing :: web-platform-tests, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 42032 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/42032
Details from upstream follow.

David Bokan <[e-mail]> wrote:

scroll-to: Improve handling for invalid percent encoding

https://github.com/WICG/scroll-to-text-fragment/issues/229 pointed out
that percent encoding in the spec didn't restrict to just two
hex-digits. That was fixed in the spec so this CL ensures malformed
percent-encodings in a text-directve cause the directive to be invalid.

Bug: 1482847
Change-Id: If4c0b8918b355d644d31742c08b92b5c6da59318
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4874539
Reviewed-by: Daniel Cheng \<[e-mail]>
Commit-Queue: David Bokan \<[e-mail]>
Cr-Commit-Position: refs/heads/main@{#1199827}

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=63dfc8ab914386728e1d02893dfd0fb384b7aa14

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 9 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 2 tests and 3 subtests

Status Summary

Firefox

OK : 2
PASS : 3
FAIL : 7

Chrome

OK : 2
PASS : 7
FAIL : 3

Safari

OK : 1
FAIL : 3
TIMEOUT: 2
NOTRUN : 6

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

• /scroll-to-text-fragment/percent-encoding.html [wpt.fyi]: OK [GitHub], SKIP [Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows11-32-2009-qr-debug, Gecko-windows11-32-2009-qr-opt, Gecko-windows11-64-2009-qr-debug, Gecko-windows11-64-2009-qr-opt] (Chrome: OK, Safari: TIMEOUT)
  • Test navigation with fragment: Percent-encoded "%" char..: FAIL (Chrome: PASS, Safari: TIMEOUT)
  • Test navigation with fragment: Percent-encoding limited to two digits..: FAIL (Chrome: PASS, Safari: NOTRUN)
  • Test navigation with fragment: Percent-encoded "%%F".: FAIL (Chrome: PASS, Safari: NOTRUN)
  • Test navigation with fragment: Percent-encoding multibyte codepoint (CHECKMARK)..: FAIL (Chrome: PASS, Safari: NOTRUN)
• /scroll-to-text-fragment/same-document-tests.html [wpt.fyi]: OK [GitHub], SKIP [Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows11-32-2009-qr-debug, Gecko-windows11-32-2009-qr-opt, Gecko-windows11-64-2009-qr-debug, Gecko-windows11-64-2009-qr-opt] (Chrome: OK, Safari: OK)
  • Basic text directive navigation: FAIL (Chrome: PASS, Safari: FAIL)
  • Basic element id fallback: FAIL (Chrome: PASS, Safari: FAIL)
  • Malformed text directive element id fallback: FAIL (Chrome: PASS, Safari: FAIL)

Tests Disabled in Gecko Infrastructure

• /scroll-to-text-fragment/percent-encoding.html [wpt.fyi]: OK [GitHub], SKIP [Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows11-32-2009-qr-debug, Gecko-windows11-32-2009-qr-opt, Gecko-windows11-64-2009-qr-debug, Gecko-windows11-64-2009-qr-opt] (Chrome: OK, Safari: TIMEOUT)
• /scroll-to-text-fragment/same-document-tests.html [wpt.fyi]: OK [GitHub], SKIP [Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows11-32-2009-qr-debug, Gecko-windows11-32-2009-qr-opt, Gecko-windows11-64-2009-qr-debug, Gecko-windows11-64-2009-qr-opt] (Chrome: OK, Safari: OK)

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/mozilla-central/rev/6fddb4ceb3f2
[wpt PR 42032] - scroll-to: Improve handling for invalid percent encoding, a=testonly

Comment 4

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/6fddb4ceb3f2