1854768 - Relay prompt does not show up when creating a new account

Status: NEW

(Toolkit :: Password Manager, defect, P3)

Description

[Vicky Chin [:vchin]]

Attachment: Screenshot 2023-09-22 at 11.22.07 PM.png

I do not see the Relay prompt when creating a new account. It can be reproduced on multiple websites e.g. Best Buy, Home Depot, Staples etc. I have the 1Password extension installed, and am signed in to FxA and already have one Relay mask created.

See attached screenshot.

Comment 1

[Vicky Chin [:vchin]]

It appears that signon.firefoxRelay.feature was only set to available not enabled. I am using Nightly and wasn't enrolled in the experiment. Should this be flipped on for FxA users in Nightly by default?

Comment 2

[Luke Crouch [:groovecoder]]

Hmm ... the roll-out is set to 100% of Firefox 118+ users who do not already have Relay, and it has rolled out to over 1M users now.

:vchin - do you already have Relay?

:serg - If someone already has Relay, they should already get the feature right? IIRC, "firefoxRelayIntegration": true sets the feature to available right? So it looks like the roll-out worked, but the code might not be showing the item?

Comment 3

[Sergey Galich [:serg]]

The integration started to work once we set signon.firefoxRelay.feature=enabled manually, so it's definitely not an account problem.
about:studies didn't have anything relay related, so my guess is that Nimbus didn't enroll that system.

Comment 4

[Vicky Chin [:vchin]]

Yes I already had Relay and the integration did not show up until I flipped the pref to enabled. It was previously set to available. This is on Nightly 120. Perhaps we need to flip the pref to enabled for those who already have Relay?

Comment 5

[Luke Crouch [:groovecoder]]

(In reply to Vicky Chin [:vchin] from comment #4)

Yes I already had Relay and the integration did not show up until I flipped the pref to enabled. It was previously set to available. This is on Nightly 120. Perhaps we need to flip the pref to enabled for those who already have Relay?

Hmm ... Our first launch was to those who already have Relay. Then we changed the code from existing Relay users, to checking Nimbus for the feature. In Nimbus, we targeted the feature roll-outs at NON-Relay users, specifically so that we wouldn't accidentally change the pref for existing Relay users with the available feature already.

:vchin - Was the UI only missing when you saw the Form Autofill drop-down? Or was it also missing when you saw, e.g., a username field with the credential manager drop-down? (e.g., https://mozilla.github.io/form-fill-examples/password_manager/login_and_pw_change_forms.html)

Comment 6

[Luke Crouch [:groovecoder]]

(In reply to Vicky Chin [:vchin] from comment #4)

Yes I already had Relay and the integration did not show up until I flipped the pref to enabled. It was previously set to available. This is on Nightly 120. Perhaps we need to flip the pref to enabled for those who already have Relay?

Oh! I think I see. Our roll-out is targeting Firefox 118+ on Release. That's why your profile doesn't match. Hmm ... we could-have/should-have made that Firefox 118+ on any channel !

We could set up ANOTHER roll-out (because 5th times the charm right?) that would give the feature to Firefox 118+ on all channels. But I'm not sure how many people that would apply to.