1855023 - Implement basic "browsingContext.locateNodes" command for CSS selector

Status: RESOLVED FIXED

(Remote Protocol :: WebDriver BiDi, enhancement, P2)

Description

[Henrik Skupin [:whimboo][⌚️UTC+1] (away from Feb 12th - Feb 22nd)]

Once the following PR has been landed we should implement the browsingContext.locateNodes command.

https://github.com/w3c/webdriver-bidi/pull/547

We should basically be able to use a lot of the existing code for Marionette and as such make those existent methods available via a shared module for both protocols.

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+1] (away from Feb 12th - Feb 22nd)]

The initial set of tests will be downstreamed via bug 1859347.

Comment 2

[Henrik Skupin [:whimboo][⌚️UTC+1] (away from Feb 12th - Feb 22nd)]

We are going to move out the XPath and innerText locators to separate bugs to make it a bit easier to get the initial landing done.

Comment 3

[Alexandra Borovova [:Sasha]]

Attachment: Bug 1855023 - [bidi] Implement basic "browsingContext.locateNodes" command for CSS selector.

Comment 4

[Alexandra Borovova [:Sasha]]

Attachment: Bug 1855023 - [wpt] Fix bidi testing module to work with "browsingContext.locateNodes" command.

Depends on D196740

Comment 5

[Alexandra Borovova [:Sasha]]

Attachment: Bug 1855023 - [wdspec] Fix tests and update metadata for "browsingContext.locateNodes" command.

Depends on D196741

Comment 6

[Alexandra Borovova [:Sasha]]

Attachment: Bug 1855023 - [wdspec] Add more tests for "browsingContext.locateNodes" command.

Depends on D196742

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/339134cf30e4
[bidi] Implement basic "browsingContext.locateNodes" command for CSS selector. r=webdriver-reviewers,jdescottes,whimboo
https://hg.mozilla.org/integration/autoland/rev/6bf767d58538
[wpt] Fix bidi testing module to work with "browsingContext.locateNodes" command. r=webdriver-reviewers,jgraham
https://hg.mozilla.org/integration/autoland/rev/e6c467604219
[wdspec] Fix tests and update metadata for "browsingContext.locateNodes" command. r=webdriver-reviewers,jdescottes
https://hg.mozilla.org/integration/autoland/rev/6289cc447577
[wdspec] Add more tests for "browsingContext.locateNodes" command. r=webdriver-reviewers,jdescottes,whimboo

Comment 8

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/43755 for changes under testing/web-platform/tests

Comment 9

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/339134cf30e4
https://hg.mozilla.org/mozilla-central/rev/6bf767d58538
https://hg.mozilla.org/mozilla-central/rev/e6c467604219
https://hg.mozilla.org/mozilla-central/rev/6289cc447577

Comment 10

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot