18551 - Binaries built with HP-UX gcc need chatr +s enable post-command and +s flag when linking

Status: RESOLVED FIXED

(SeaMonkey :: Build Config, defect, P3)

Description

[Richard Lloyd]

The configure.in at the top-level of the source tree only links with +s
and uses "chatr +s enable" when compiling with HP-UX's cc (see lines 487-502
approximately).

However, gcc on HP-UX uses HP's ld when linking, so I would suggesting adding
+s to the gcc DSO_LDOPTS (line 497 approx) thus:

         DSO_LDOPTS='-b +s -E -L$(DIST)/bin -L$(DIST)/lib'

Also, the MOZ_POST_PROGRAM_COMMAND should be set to 'chatr +s enable' for both
HP-UX cc and GNU's gcc - this can be done by moving the assignment from the
HP cc section (line 495) to after the if...fi:

     fi
     MOZ_POST_PROGRAM_COMMAND='chatr +s enable'
     AC_DEFINE(NSCAP_DISABLE_DEBUG_PTR_TYPES)

Without these change, I found that the M10 build (when compiling with gcc/g++
on HP-UX) resulted in shared libraries that didn't pick up SHLIB_PATH and
apprunner/viewer binaries that also didn't pick up that variable either.

Comment 1

[Jon Granrose]

accepting bug.  cc'd jdunn for comments.

Comment 2

[Jim Dunn]

Both of these look good (we just haven't built with gcc lately)
r=jdunn

Comment 3

[Jim Dunn]

Jon here is the diff.
r=jdunn
or assign the bug to me and I will check it in

Index: configure.in
===================================================================
RCS file: /cvsroot/mozilla/configure.in,v
retrieving revision 1.539
diff -r1.539 configure.in
510d509
<       MOZ_POST_PROGRAM_COMMAND='chatr +s enable'
512c511
<       DSO_LDOPTS='-b -E -L$(DIST)/bin -L$(DIST)/lib'
---
>       DSO_LDOPTS='-b +s -E -L$(DIST)/bin -L$(DIST)/lib'
515a515
>     MOZ_POST_PROGRAM_COMMAND='chatr +s enable'

Comment 4

[Jon Granrose]

mass set milestone to M13

Comment 5

[Jon Granrose]

punt to jdunn for checkin per conversation.

Comment 6

[Jim Dunn]

Checked in configure.in