Closed Bug 1855144 Opened 2 years ago Closed 1 year ago

Remove global constructors from dom/html/MediaError.cpp

Categories

(Core :: DOM: Core & HTML, task)

task

Tracking

()

RESOLVED FIXED
136 Branch
Tracking Status
firefox136 --- fixed

People

(Reporter: sergesanspaille, Assigned: sergesanspaille)

References

(Depends on 1 open bug, Blocks 1 open bug)

Details

Attachments

(1 file)

Using the frozen library we can use compile-time initialized hash table instead of runtime initialized ones.

The Bugbug bot thinks this bug should belong to the 'Core::DOM: Core & HTML' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.

Component: General → DOM: Core & HTML
Attachment #9355023 - Attachment description: WIP: Bug 1855144 - Use frozen to store statically initialized hash map in dom/html/MediaError.cpp → Bug 1855144 - Use frozen to store statically initialized hash map in dom/html/MediaError.cpp
Assignee: nobody → sguelton
Status: NEW → ASSIGNED
Attachment #9355023 - Attachment description: Bug 1855144 - Use frozen to store statically initialized hash map in dom/html/MediaError.cpp → WIP: Bug 1855144 - Use frozen to store statically initialized hash map in dom/html/MediaError.cpp
Attachment #9355023 - Attachment description: WIP: Bug 1855144 - Use frozen to store statically initialized hash map in dom/html/MediaError.cpp → Bug 1855144 - Use plain array to store statically initialized hash map in dom/html/MediaError.cpp
Pushed by sguelton@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/334dceffdf7b Use plain array to store statically initialized hash map in dom/html/MediaError.cpp r=smaug

Backed out 4 changesets (Bug 1855143, Bug 1855144, Bug 1855136, Bug 1855145) for causing mochitest failures @ test_bug1354633_media_error.html.

TEST-UNEXPECTED-FAIL | browser/components/resistfingerprinting/test/mochitest/test_bug1354633_media_error.html | Error message in allowlist: 404: Not Found - got "", expected "404: Not Found"
Flags: needinfo?(sguelton)
Attachment #9355023 - Attachment description: Bug 1855144 - Use plain array to store statically initialized hash map in dom/html/MediaError.cpp → Bug 1855144 - Use plain array to store statically initialized hash map in dom/html/MediaError.cpp r=glandium
Attachment #9355023 - Attachment description: Bug 1855144 - Use plain array to store statically initialized hash map in dom/html/MediaError.cpp r=glandium → Bug 1855144 - Use plain array to store statically initialized hash map in dom/html/MediaError.cpp r=glandium
Attachment #9355023 - Attachment description: Bug 1855144 - Use plain array to store statically initialized hash map in dom/html/MediaError.cpp r=glandium → Bug 1855144 - Use plain array to store statically initialized hash map in dom/html/MediaError.cpp r=smaug!
Pushed by sguelton@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/750d66437a0f Use plain array to store statically initialized hash map in dom/html/MediaError.cpp r=smaug
Status: ASSIGNED → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → 136 Branch
Flags: needinfo?(sguelton)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: