18552 - run-mozilla.sh script doesn't set SHLIB_PATH

Status: VERIFIED FIXED

(Core Graveyard :: Tracking, defect, P3)

Description

[Richard Lloyd]

On HP-UX, you set SHLIB_PATH, not LD_LIBRARY_PATH, to indicate the dir paths of
shared libraries to be picked up. The run-mozilla.sh script (run by both
mozilla-apprunner.sh and mozilla-viewer.sh) only sets LD_LIBRARY_PATH though,
meaning it doesn't work on HP-UX "as is".

My suggestion is that you add the setting of SHLIB_PATH in exactly the same
way as LD_LIBRARY_PATH is set (e.g insert this at around line 362 or so):

##
## Set SHLIB_PATH
##
if [ -n "$SHLIB_PATH" ]
then
   SHLIB_PATH=${MOZ_DIST_BIN}${SHLIB_PATH+":$SHLIB_PATH"}
else
   SHLIB_PATH=${MOZ_DIST_BIN}
fi

And maybe add in a SHLIB_PATH line that's output to stdout:

echo "  LD_LIBRARY_PATH=$LD_LIBRARY_PATH"
echo "       SHLIB_PATH=$SHLIB_PATH"
echo "      MOZ_PROGRAM=$MOZ_PROGRAM"

Comment 1

[Steve Lamm]

Attachment: Potential patch

Comment 2

[Steve Lamm]

I added a patch. Someone else can review it and check it in. The "-n" test was
redundant, so I took it out. We could make the script test for HP-UX, but
setting SHLIB_PATH for other platforms should not hurt them.

Comment 3

[Jim Dunn]

I figured I would add AIX/LIBPATH in also

Index: run-mozilla.sh
===================================================================
RCS file: /cvsroot/mozilla/build/unix/run-mozilla.sh,v
retrieving revision 1.14
diff -r1.14 run-mozilla.sh
361a362,379
> ##
> ## Set SHLIB_PATH for HPUX
> ##
> if [ -n "$SHLIB_PATH" ]
> then
>       SHLIB_PATH=${MOZ_DIST_BIN}${SHLIB_PATH+":$SHLIB_PATH"}
> else
>       SHLIB_PATH=${MOZ_DIST_BIN}
> fi
> ##
> ## Set LIBPATH for AIX
> ##
> if [ -n "$LIBPATH" ]
> then
>       LIBPATH=${MOZ_DIST_BIN}${LIBPATH+":$LIBPATH"}
> else
>       LIBPATH=${MOZ_DIST_BIN}
> fi
364a383,384
> echo "       SHLIB_PATH=$SHLIB_PATH"
> echo "          LIBPATH=$LIBPATH"
370a391
> export SHLIB_PATH LIBPATH

Comment 4

[leger]

Setting QA contact to build team to verify

Comment 5

[Jon Granrose]

marking verified.  looked at hpux10.20 m12 build on mozilla.org which has build 
date 19990823(?) but has this change in it.