1855330 - Update our vendored abseil-cpp import in libwebrtc

Status: RESOLVED FIXED

(Core :: WebRTC, task, P2)

Description

[Ryan VanderMeulen [:RyanVM]]

Right now, libwebrtc has the only available import of abseil-cpp. Various libraries such as protobuf are starting to make it a hard dependency, so the age of that import is becoming a blocking issue for being able to update other libraries. While we have bug 1788569 on file for hopefully having an independent import of the library vendored in that lives outside libwebrtc, it would be helpful in the short term if we could at least update the one that lives in libwebrtc.

Taking in the latest LTS release (20230802.1) would be preferable to avoid bringing back bug 1833541.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'Core::WebRTC' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.

Comment 2

[Michael Froman [:mjf]]

I've got a proof-of-concept build working, but had to hack around a few things that need cleanup. Some details:

• Currently libwebrtc is using third_party commit 31edcc46d68.
• The request above was for 20230802.1 (commit fb3621f4), which is based off commit fdf5be11.
• Current libwebrtc/third_party commit includes abseil-cpp from commit 6ab667fd (114 commits newer than fdf5be11).

I will be prepping the actual patches asap. Please keep in mind that our current build of abseil-cpp in libwebrtc/third_party has portions of the build disabled. There may be additional changes needed to enable building new parts of abseil-cpp for use with protobuf. We can address those issues separately.

Comment 3

[Michael Froman [:mjf]]

Attachment: Bug 1855330 - pt1 - remove google_benchmark from libwebrtc/third_party vendoring. r?ng!

Upstream libwebrtc/third_party removes dependency on the one file
we were using from google_benchmark. We can stop vendoring that
directory now that we're updating to our third_party import based
off commit 31edcc46d68.

Comment 4

[Michael Froman [:mjf]]

Attachment: Bug 1855330 - pt2 - vendor libwebrtc/third_party from build-31edcc46d68. r?ng!

Depends on D190093

Comment 5

[Michael Froman [:mjf]]

Attachment: Bug 1855330 - pt3 - add shim targets to limit BUILD.gn changes. r?ng!

Adding these shim targets reduces the need to modify many BUILD.gn
files by removing those deps. We can retroactively fix the places
we're already removing those deps in a future bug.

Depends on D190094

Comment 6

[Michael Froman [:mjf]]

Attachment: Bug 1855330 - pt4 - BUILD.gn fixes for updated libwebrtc/third_party. r?ng!

Depends on D190095

Comment 7

[Michael Froman [:mjf]]

Attachment: Bug 1855330 - pt4 - BUILD.gn fixes for updated libwebrtc/third_party. r?ng! - moz.build file updates

Depends on D190096

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1f623969b862
pt1 - remove google_benchmark from libwebrtc/third_party vendoring. r=ng
https://hg.mozilla.org/integration/autoland/rev/5350f0a3629f
pt2 - vendor libwebrtc/third_party from build-31edcc46d68. r=ng,webrtc-reviewers
https://hg.mozilla.org/integration/autoland/rev/a150bc95a2e9
pt3 - add shim targets to limit BUILD.gn changes. r=ng,webrtc-reviewers
https://hg.mozilla.org/integration/autoland/rev/60c4a7790fc5
pt4 - BUILD.gn fixes for updated libwebrtc/third_party. r=ng,webrtc-reviewers
https://hg.mozilla.org/integration/autoland/rev/8df4677f8728
pt4 - BUILD.gn fixes for updated libwebrtc/third_party. r=ng,webrtc-reviewers - moz.build file updates

Comment 9

[Ryan VanderMeulen [:RyanVM]]

Thank you!

Comment 10

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/1f623969b862
https://hg.mozilla.org/mozilla-central/rev/5350f0a3629f
https://hg.mozilla.org/mozilla-central/rev/a150bc95a2e9
https://hg.mozilla.org/mozilla-central/rev/60c4a7790fc5
https://hg.mozilla.org/mozilla-central/rev/8df4677f8728