1855493 - Loading animation does not run

Status: VERIFIED FIXED

(Firefox Graveyard :: Shopping, defect, P1)

Description

[kpatenio]

STR:

1. Open any product page
2. Ensure you can see loading state (easier to see with slow connectivity)

Expected:

• loading state should have animations for different placeholder boxes

Actual:

• there are no animations

Notes:

• only exception is offline connectivity - there should be no animations for that state
• I suspect this is due to https://searchfox.org/mozilla-central/rev/fd2325f5b2a5be8f8f2acf9307285f2b7de06582/browser/components/shopping/content/shopping-container.mjs#257. When running the VSCode lit-plugin, a message appears for this line: Type '"" | "class='animate'"' is not a Lit 2 directive'lit-plugin(no-incompatible-type-binding)(2304). The animations seemed to work before despite this; regardless, re-writing to class=${animate ? "animate : ""} fixes the issue.

Comment 1

[kpatenio]

Attachment: Bug 1855493 - fix loading animation for shopping sidebar

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d60788c1a506
fix loading animation for shopping sidebar r=shopping-reviewers,niklas

Comment 3

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/d60788c1a506

Comment 4

[kpatenio]

Comment on attachment 9355376 [details]
Bug 1855493 - fix loading animation for shopping sidebar

Beta/Release Uplift Approval Request

• User impact if declined: Animations won't run during the loading state for the Shopping sidebar (ex. viewing a product page and waiting for data to populate). Why this matters: the animation helps distinguish between the loading state and the offline state.

When a user views the sidebar without Internet connection, the sidebar looks visually similar to when it loads data; the only difference is that there's no animation. Therefore, users may confuse the loading state with the offline state, if not addressed sooner.

• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): The animation itself is actually already implemented via CSS. What this patch does is modify how we assign the classname that the loading component needs to animate vs not animate; it is also a one line change.
• String changes made/needed:
• Is Android affected?: No

Comment 5

[Dianna Smith [:diannaS]]

Comment on attachment 9355376 [details]
Bug 1855493 - fix loading animation for shopping sidebar

Approved for 119.0b5

Comment 6

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-beta/rev/4438587f3acb

Comment 7

[Peter Magyari (Desktop QA)]

Verified fixed on Beta 119.0b5 (20231004091611) and Nightly 120.0a1 (20231004155628).
The loading animation is visible in the sidebar while the cards are being populated.