1855759 - store canary value in oskeystore and collect telemetry on its availability

Status: RESOLVED FIXED

(Core :: Security: PSM, enhancement, P1)

Description

[Dana Keeler (she/her) (use needinfo) [:keeler]]

The nsIOSKeyStore backend(s) seem to have a data loss issue where previously-stored secrets become unavailable or even change (?!) (see e.g. bug 1778337). To investigate this, we should store a canary value and collect telemetry on its availability and value, to potentially narrow down where the issue is.

Comment 1

[Dana Keeler (she/her) (use needinfo) [:keeler]]

Attachment: Bug 1855759 - self-test oskeystore and collect telemetry on the results r?jschanck

Comment 2

[Dana Keeler (she/her) (use needinfo) [:keeler]]

Attachment: request.md

Comment 3

[Chris H-C :chutten]

Comment on attachment 9356459 [details]
request.md

PRELIMINARY NOTE:

Since this is a Glean collection in mozilla-central, did you know you could use ./mach data-review to help generate your data review request form? Be sure to give it a try next time!

DATA COLLECTION REVIEW RESPONSE:

Is there or will there be documentation that describes the schema for the ultimate data set available publicly, complete and accurate?

Yes.

Is there a control mechanism that allows the user to turn the data collection on and off?

Yes. This collection can be controlled through Firefox's Preferences.

If the request is for permanent data collection, is there someone who will monitor the data over time?

No. This collection will expire in Firefox 126.

Using the category system of data types on the Mozilla wiki, what collection type of data do the requested measurements fall under?

Category 1, Technical.

Is the data collection request for default-on or default-off?

Default on for all channels.

Does the instrumentation include the addition of any new identifiers?

No.

Is the data collection covered by the existing Firefox privacy notice?

Yes.

Does the data collection use a third-party collection tool?

No.

---

Result: datareview+

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e9d46c179688
self-test oskeystore and collect telemetry on the results r=jschanck,dthayer

Comment 5

[Sandor Molnar[:smolnar]]

Backed out for causing build bustages

Backout link: https://hg.mozilla.org/integration/autoland/rev/8ddc79ff897f20340bcbb983f6fef8a10e1ce46a

Push with failures

Failure log -> PROCESS-CRASH | Shutdown hanging at step XPCOMShutdownThreads. Something is blocking the main-thread. [@ mozilla::(anonymous namespace)::RunWatchdog] | Profiling run

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a6f2a841b112
self-test oskeystore and collect telemetry on the results r=jschanck,dthayer

Comment 7

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/a6f2a841b112