1855771 - No info about these reviews text should be marked up as a heading

Status: VERIFIED FIXED

(Firefox Graveyard :: Shopping, defect)

Description

[Anna Yeddi [:ayeddi]]

Attachment: Win-NVDA-announces-this-implicit-heading-as-static-text.png

Preconditions:

Set the browser.shopping.experience2023.enabled - TRUE
Set the browser.shopping.experience2023.optedIn - 1

Steps to reproduce

1. Reach a product that does not have a Fakespot rating yet, i.e. https://www.amazon.com/Boost-Infinite-required-starting-Unlimited/dp/B0CHBQQQSB/ref=sr_1_1?crid=21OVAQAMPSRDN&keywords=iphone+15&qid=1695377359&sprefix=iphone+1%2Caps%2C200&sr=8-1
2. Click the Check review Quality button.
3. Review the No info about these reviews visual appearance
4. With a screen reader, review the announcement about this implicit heading
5. With a screen reader running, use keyboard shortcut to navigate to the heading (with NVDA on WinOS press H to navigate between headings)

Expected result

• The No info about these reviews should be announced as a heading, i.e. heading level 2, because it visually appears as such and is comparable with the Settings heading, for instance.
• Screen reader user could use a keyboard shortcut to navigate to this heading

Actual result

• The No info about these reviews is a static text, it does not appear in the heading hierarchy
• Screen reader shortcuts do not work to navigate to this element

Comment 1

[kpatenio]

Attachment: Bug 1855771 - set unanalyzed-product-card heading as h2. r=#shopping-reviewers!

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3fb6f22b20a1
set unanalyzed-product-card heading as h2. r=shopping-reviewers,desktop-theme-reviewers,Gijs,dao

Comment 3

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/3fb6f22b20a1

Comment 4

[Rares Doghi, Desktop QA]

This issue is verified as fixed in our latest Nightly build 120.0a1 (2023-10-19).