1855959 - Loongson64: change `MacroAssembler::storeUncanonicalized{Float32,Double} to return a `FaultingCodeOffset`.

Status: RESOLVED FIXED

(Core :: JavaScript: WebAssembly, enhancement, P5)

Description

[Julian Seward [:jseward]]

Without this change, the build will fail, due to the assembler changes made by
bug 1846474 (D187462).

Comment 1

[Zhao Jiazhong]

Attachment: Bug 1855959 - [loong64] make some assembler routines return FaultingCodeOffset. r=jseward

Port D187462 to LoongArch64 platform.

Comment 2

[Zhao Jiazhong]

Attachment: Bug 1855959 - [loong64] Implement function `SummarizeTrapInstruction`. r=nbp

Port D187459 to LoongArch64 platform.

Comment 3

[Nicolas B. Pierron [:nbp]]

I am adding the leave-open keyword as I am landing one of the patches, while the other would be reviewed later.
Once both patches are merged in mozilla-central, we can remove the leave-open keyword and flag this bug as Fixed.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/07e5e900d9cc
[loong64] Implement function `SummarizeTrapInstruction`. r=nbp

Comment 5

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/07e5e900d9cc

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/625098a55803
[loong64] make some assembler routines return FaultingCodeOffset. r=nbp

Comment 7

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/625098a55803

Comment 8

[Zhao Jiazhong]

Comment on attachment 9360549 [details]
Bug 1855959 - [loong64] Implement function SummarizeTrapInstruction. r=nbp

Beta/Release Uplift Approval Request

• User impact if declined: Firefox failed to build on LoongArch64 platform.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): The fix mainly modified LoongArch64 codes, the chance that other platform will be affected is small.
• String changes made/needed:
• Is Android affected?: No

Comment 9

[Dianna Smith [:diannaS]]

Comment on attachment 9359987 [details]
Bug 1855959 - [loong64] make some assembler routines return FaultingCodeOffset. r=jseward

Approved for 120.0b8

Comment 10

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-beta/rev/85f29997e8d3
https://hg.mozilla.org/releases/mozilla-beta/rev/9405e5ab3a4a