1856203 - Failing WPTs html/canvas/offscreen/text/2d.text.drawing.style.letterSpacing.change.font.[worker.]html

Status: RESOLVED FIXED

(Core :: Graphics: Canvas2D, enhancement)

Description

[Thomas Wisniewski [:twisniewski]]

We're failing these two WPTs:

• https://wpt.fyi/results/html/canvas/offscreen/text/2d.text.drawing.style.letterSpacing.change.font.html
• https://wpt.fyi/results/html/canvas/offscreen/text/2d.text.drawing.style.letterSpacing.change.font.worker.html

It looks like a rounding/test-fuzzing issue:

!EQ(167.20000076293945, 167.1999969482422)

Comment 1

[Jonathan Kew [:jfkthame]]

Yeah, this is not a real bug, just the limitations of floating-point accuracy. The test should be doing an approximate comparison, not requiring an exact match (just like a bunch of the other canvas text tests already do).

Comment 2

[Jonathan Kew [:jfkthame]]

Attachment: Bug 1856203 - Use assert_approx_equals in canvas letter-spacing test, to allow for floating-point discrepancies in text measurement. r=#gfx-reviewers

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c67416582c22
Use assert_approx_equals in canvas letter-spacing test, to allow for floating-point discrepancies in text measurement. r=gfx-reviewers,lsalzman

Comment 4

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/42959 for changes under testing/web-platform/tests

Comment 5

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/c67416582c22

Comment 6

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot