1856261 - Reload/back/forward buttons disappear upon opening an extension's menu on larger screens

Status: VERIFIED FIXED

(Fenix :: General, defect, P1)

Description

[axel]

User Agent: Mozilla/5.0 (Android 8.0.0; Mobile; rv:109.0) Gecko/120.0 Firefox/120.0

Steps to reproduce:

1. Go to the 3-dots menu on the top right, and select Add-Ons.
2. If you have one selectable in this menu installed (e.g. uBlock Origin), click on it.
3. Exit this menu.
4. The three buttons on the top left are missing, leaving the home button by itself. Doubles are still accessible by the 3-dot menu.

Actual results:

The reload, back, and forward buttons on the top left disappear upon exiting the addon's menu. They seem to reappear upon searching a query in a new tab, but there may be other triggers both to the disappearing and reappearing I have not found.

Expected results:

They should have remained as they were before the menu was opened, and visible. It worked as intended in older versions (the only other version I've tested being sometime around 108-110)
This is not reproducible on smaller mobile devices such as phones (though perhaps in landscape mode?) due to the screen size hiding them anyway.

Comment 1

[jackyzy823]

Easier way to reproduce:

STR:

1. Open page in tablet ( You could observe that reload, back, and forward buttons appear)
2. Click 3-dots menu and select "settings"
3. Go back . (You could observe that reload, back, and forward buttons disappear)
4. Click on URL bar then go back. ( You could observe that reload, back, and forward buttons appear again)

Comment 2

[BMO Github Automation]

Attachment: [mozilla-mobile/firefox-android] Bug 1856261 - updateToolbarActions shoudn't be short-circuited (#3888)

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

The severity field is not set for this bug.
:jonalmeida, could you have a look please?

For more information, please visit BugBot documentation.

Comment 4

[BMO Github Automation]

Authored by https://github.com/jackyzy823
https://github.com/mozilla-mobile/firefox-android/commit/b307dd940f29ce8ade5f7c6c12a04ec595783ff0
[main] Bug 1856261 - Reset isTablet when onDestroyView

Comment 5

[Delia Pop]

Attachment: QA.mp4

Verified fixed on Nightly 121.0a1 with Lenovo Yoga Tab 11 (Android 12).

Comment 6

[Chris Peterson [:cpeterson]]

jackyzy823, we'd like to uplift your bug fix from Nightly 121 to Beta 120 (since we're planning to launch expanded add-on support in 120).

Have you requested uplifts before? If you don't have the time, no problem. I can find another engineer to submit the uplift request.

Here are instructions:

https://github.com/mozilla-mobile/firefox-android/blob/main/docs/shared/uplift_guide.md

Comment 7

[jackyzy823]

Hello :cpeterson, I haven't requested uplifts before. Please find another engineer to submit the uplift request. Thanks. :)

Comment 8

[William Durand [:willdurand]]

I am going to uplift that patch.

Comment 9

[BMO Github Automation]

Attachment: [mozilla-mobile/firefox-android] Bug 1856261 - reset isTablet when onStop (backport #3888) (#4279)

Comment 10

[William Durand [:willdurand]]

Comment on attachment 9360950 [details] [review]
[mozilla-mobile/firefox-android] Bug 1856261 - reset isTablet when onStop (backport #3888) (#4279)

Beta/Release Uplift Approval Request

• User impact if declined: Android users with a tablet are likely affected by this.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): It's low risk because it is a simple change and it has been verified by QA. Given our public comms about "more extensions available on Firefox Android", it'd be good to get that minor bug fixed in 120 so that tablet users don't run into it.
• String changes made/needed:
• Is Android affected?: Yes

Comment 11

[Dianna Smith [:diannaS]]

Comment on attachment 9360950 [details] [review]
[mozilla-mobile/firefox-android] Bug 1856261 - reset isTablet when onStop (backport #3888) (#4279)

Approved for Mobile 120.0b4

Comment 12

[BMO Github Automation]

Authored by https://github.com/jackyzy823
https://github.com/mozilla-mobile/firefox-android/commit/7edc5311225940b291b0351cba99c0665977b4fb
[releases_v120] Bug 1856261 - Reset isTablet when onDestroyView

Comment 13

[Adina Petridean]

Verified fixed on Firefox Beta 120.0b4 with Sony Xperia (Android 6.0.1).