With about:blank patch test_group_mouseevents.html turns from intermittent to perma orange
Categories
(Core :: Panning and Zooming, defect, P2)
Tracking
()
People
(Reporter: hsivonen, Unassigned)
References
Details
When the patch for bug 543435 is applied, https://searchfox.org/mozilla-central/source/gfx/layers/apz/test/mochitest/test_group_mouseevents.html turns into a permafailure.
Bug 1776963 is already on file for it failing intermittently.
When I've tried to resolve this, I've noticed that the test is very timing-sensitive: adding some logging to stdout can change timing enough to make the test pass when it fails without a logging statement. The patch adds a logging statement for "Printing something here to avoid failure". That actually helped with an earlier iteration of the patch for bug 543435 but no longer does.
Understanding this would benefit from a look by the graphics team.
Steps to reproduce
- Apply the patch for bug 543435
- Run the test
gfx/layers/apz/test/mochitest/test_group_mouseevents.html
|
||
Comment 1•2 years ago
|
||
Setting the same priority/severity as bug 543435. I will look into detail the failure.
|
|
||
Comment 2•2 years ago
|
||
Though I am not yet sure where the underlying problem is, I am sure that the patch for bug 543435 breaks our layout history state machinery.
The sub test name causing test_group_mouseevents.html timeout is helper_visualscroll_nonrcd_rsf.html. And the test in question reconstructs a sub document's root scrollable frame. And the during the reconstruction, we do get the last layout history state via this nsFrameConstructorState, but with the patch we somehow get null history state unfortunately.
CCing Henri.
|
Reporter | |
Comment 3•2 years ago
|
||
Thank you! It looks like nsDocShell::mActiveEntry is nullptr for the initial about:blank here. (When the test passes without the patch, the about:blank isn't the truly initial one but a second about:blank, which the patch is getting rid of.)
|
|
Reporter | |
Comment 4•2 years ago
|
||
This works now. Thanks.
|
|
||
Comment 5•2 years ago
|
||
\o/
Description
•