1856335 - [wpt-sync] Sync PR 42213 - Reland: [soft navigations] Enable keyboard shortcuts as soft navigation triggers

Status: RESOLVED FIXED

(Testing :: web-platform-tests, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 42213 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/42213
Details from upstream follow.

Yoav Weiss <[e-mail]> wrote:

Reland: [soft navigations] Enable keyboard shortcuts as soft navigation triggers

Following the discussion on issue #3 [1], this CL adds support to soft
navigations triggered by keyboard shortcuts, by adding unfocused keydown
events to the events that can trigger the soft navigation heuristic.

This is a reland of [2], rebased and which fixes the unguarded
ScriptState access in event_dispatcher, which caused a crash.

[1] https://github.com/WICG/soft-navigations/issues/3
[2] https://chromium-review.googlesource.com/c/chromium/src/+/4839506

Bug: 1478772, 1480047
Change-Id: I6428e0635222366d880dd908f04f2273b6bf8b44
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4900577
Reviewed-by: Ian Clelland \<[e-mail]>
Commit-Queue: Yoav Weiss \<[e-mail]>
Cr-Commit-Position: refs/heads/main@{#1203903}

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=7753012b32697f7ee29a0d246d6229c5400c1355

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 0 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 32 tests and 1 subtests

Status Summary

Firefox

OK : 7
PASS : 1
FAIL : 6
TIMEOUT: 42
ERROR : 4

Chrome

OK : 31
PASS : 31
TIMEOUT: 2

Safari

OK : 6
PASS : 1
FAIL : 5
TIMEOUT: 44
ERROR : 4

Links

GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

• /soft-navigation-heuristics/back.tentative.html [wpt.fyi]: TIMEOUT (Chrome: OK, Safari: TIMEOUT)
  • Detect simple soft navigation.: TIMEOUT (Chrome: PASS, Safari: TIMEOUT)
• /soft-navigation-heuristics/dropped-entries.tentative.html [wpt.fyi]: TIMEOUT (Chrome: OK, Safari: TIMEOUT)
  • Detect simple soft navigation.: TIMEOUT (Chrome: PASS, Safari: TIMEOUT)
• /soft-navigation-heuristics/hash.tentative.html [wpt.fyi]: TIMEOUT (Chrome: OK, Safari: TIMEOUT)
  • Detect hashchange event.: TIMEOUT (Chrome: PASS, Safari: TIMEOUT)
• /soft-navigation-heuristics/image-lcp-followed-by-image-softnav-lcp.tentative.html [wpt.fyi]: TIMEOUT (Chrome: OK, Safari: TIMEOUT)
  • Detect simple soft navigation.: TIMEOUT (Chrome: PASS, Safari: TIMEOUT)
• /soft-navigation-heuristics/image-lcp-followed-by-text-softnav-lcp.tentative.html [wpt.fyi]: TIMEOUT (Chrome: OK, Safari: TIMEOUT)
  • Detect simple soft navigation.: TIMEOUT (Chrome: PASS, Safari: TIMEOUT)
• /soft-navigation-heuristics/keydown.tentative.html [wpt.fyi]: TIMEOUT (Chrome: TIMEOUT, Safari: TIMEOUT)
  • Detect hashchange event.: TIMEOUT (Chrome: TIMEOUT, Safari: TIMEOUT)
• /soft-navigation-heuristics/load-classic-script-history-push.tentative.html [wpt.fyi]: TIMEOUT (Chrome: OK, Safari: TIMEOUT)
  • Detect a soft navigation triggered by an external classic script.: TIMEOUT (Chrome: PASS, Safari: TIMEOUT)
• /soft-navigation-heuristics/load-module-script-history-push.tentative.html [wpt.fyi]: TIMEOUT (Chrome: OK, Safari: TIMEOUT)
  • Detect a soft navigation triggered by an external module script.: TIMEOUT (Chrome: PASS, Safari: TIMEOUT)
• /soft-navigation-heuristics/multiple-paint-entries-buffered.tentative.html [wpt.fyi]: TIMEOUT (Chrome: OK, Safari: TIMEOUT)
  • Detect multiple soft navigations and ensure they buffer paint entries.: TIMEOUT (Chrome: PASS, Safari: TIMEOUT)
• /soft-navigation-heuristics/navigate-child.html [wpt.fyi]
  • Test that a navigated child window doesn't crash: FAIL (Chrome: PASS, Safari: TIMEOUT)
• /soft-navigation-heuristics/navigation-api-after-transition-commit.tentative.html [wpt.fyi]
  • Test soft navigation when navigate event intecepts with { commit: 'after-transition' }: FAIL (Chrome: PASS, Safari: FAIL)
• /soft-navigation-heuristics/navigation-api-back.tentative.html [wpt.fyi]: ERROR (Chrome: OK, Safari: ERROR)
• /soft-navigation-heuristics/navigation-api-forward.tentative.html [wpt.fyi]: ERROR (Chrome: OK, Safari: ERROR)
• /soft-navigation-heuristics/navigation-api-hash.tentative.html [wpt.fyi]
  • Test soft navigation with the Navigation API: FAIL (Chrome: PASS, Safari: FAIL)
• /soft-navigation-heuristics/navigation-api-preventDefault.tentative.html [wpt.fyi]: ERROR (Chrome: OK, Safari: ERROR)
• /soft-navigation-heuristics/navigation-api-rejected.tentative.html [wpt.fyi]
  • Test intercepted and rejected navigate event: FAIL (Chrome: PASS, Safari: FAIL)
• /soft-navigation-heuristics/navigation-api-traverseto.tentative.html [wpt.fyi]: ERROR (Chrome: OK, Safari: ERROR)
• /soft-navigation-heuristics/navigation-api-view-transition.tentative.html [wpt.fyi]
  • Navigation API interception handler + startViewTransition properly detects soft navigations: FAIL (Chrome: PASS, Safari: FAIL)
• /soft-navigation-heuristics/navigation-api.tentative.html [wpt.fyi]
  • Test soft navigation with the Navigation API: FAIL (Chrome: PASS, Safari: FAIL)
• /soft-navigation-heuristics/popstate-multiple-backs.tentative.html [wpt.fyi]: TIMEOUT (Chrome: OK, Safari: TIMEOUT)
  • A soft navigation that started from a back() call inside a popstate event is recognized by SoftNavigationHeuristics: TIMEOUT (Chrome: PASS, Safari: TIMEOUT)
• /soft-navigation-heuristics/popstate.tentative.html [wpt.fyi]: TIMEOUT (Chrome: OK, Safari: TIMEOUT)
  • A soft navigation that uses a same-document initiated popstate event is recognized by SoftNavigationHeuristics: TIMEOUT (Chrome: PASS, Safari: TIMEOUT)
• /soft-navigation-heuristics/replacestate-null-then-push.tentative.html [wpt.fyi]: TIMEOUT (Chrome: OK, Safari: TIMEOUT)
  • Detect soft navigation with replaceState that has a null URL, then
    pushState with the URL.: TIMEOUT (Chrome: PASS, Safari: TIMEOUT)
• /soft-navigation-heuristics/replacestate.tentative.html [wpt.fyi]: TIMEOUT (Chrome: OK, Safari: TIMEOUT)
  • Detect soft navigation with replaceState.: TIMEOUT (Chrome: PASS, Safari: TIMEOUT)
• /soft-navigation-heuristics/soft-navigation-detection-main-descendent.tentative.html [wpt.fyi]: TIMEOUT (Chrome: OK, Safari: TIMEOUT)
  • Detect soft navigation adding content to a main descendent.: TIMEOUT (Chrome: PASS, Safari: TIMEOUT)
• /soft-navigation-heuristics/soft-navigation-detection-non-main.tentative.html [wpt.fyi]: TIMEOUT (Chrome: OK, Safari: TIMEOUT)
  • Detect simple soft navigation.: TIMEOUT (Chrome: PASS, Safari: TIMEOUT)
• /soft-navigation-heuristics/soft-navigation-detection-web-component-lifecycle.tentative.html [wpt.fyi]: TIMEOUT (Chrome: OK, Safari: TIMEOUT)
  • Detect simple soft navigation.: TIMEOUT (Chrome: PASS, Safari: TIMEOUT)
• /soft-navigation-heuristics/soft-navigation-detection.tentative.html [wpt.fyi]: TIMEOUT (Chrome: OK, Safari: TIMEOUT)
  • Detect simple soft navigation.: TIMEOUT (Chrome: PASS, Safari: TIMEOUT)
• /soft-navigation-heuristics/soft-navigation-no-url.tentative.html [wpt.fyi]: TIMEOUT (Chrome: OK, Safari: TIMEOUT)
  • Test that a soft navigation is not detected when a URL is not passed to the history API.: TIMEOUT (Chrome: PASS, Safari: TIMEOUT)
• /soft-navigation-heuristics/text-lcp-followed-by-image-softnav-lcp.tentative.html [wpt.fyi]: TIMEOUT (Chrome: OK, Safari: TIMEOUT)
  • Detect simple soft navigation.: TIMEOUT (Chrome: PASS, Safari: TIMEOUT)
• /soft-navigation-heuristics/text-lcp-followed-by-text-softnav-lcp.tentative.html [wpt.fyi]: TIMEOUT (Chrome: OK, Safari: TIMEOUT)
  • Detect simple soft navigation.: TIMEOUT (Chrome: PASS, Safari: TIMEOUT)
• /soft-navigation-heuristics/visited-link.tentative.html [wpt.fyi]: TIMEOUT (Chrome: OK, Safari: TIMEOUT)
  • Soft navigation visited link paint tests.: TIMEOUT (Chrome: PASS, Safari: TIMEOUT)

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c91da3481d77
[wpt PR 42213] - Reland: [soft navigations] Enable keyboard shortcuts as soft navigation triggers, a=testonly
https://hg.mozilla.org/integration/autoland/rev/957d950464c7
[wpt PR 42213] - Update wpt metadata, a=testonly

Comment 4

[Cristina Horotan [:chorotan]]

https://hg.mozilla.org/mozilla-central/rev/c91da3481d77
https://hg.mozilla.org/mozilla-central/rev/957d950464c7