Closed
Bug 1856352
Opened 2 years ago
Closed 2 years ago
Harden the code reading crash annotations against linking issues
Categories
(Toolkit :: Crash Reporting, enhancement)
Toolkit
Crash Reporting
Tracking
()
RESOLVED
FIXED
120 Branch
| Tracking | Status | |
|---|---|---|
| firefox120 | --- | fixed |
People
(Reporter: gsvelto, Assigned: gsvelto)
Details
Attachments
(1 file)
Bug 1855135 highlighted the fact that a linking issue might send the mozannotation crate on a wild goose chase, trying to fetch annotations where they are not. Bug 1854179 only prevents us from reading too many annotations, but doesn't check that we really landed on the annotations array. We should hard-code a magic value nearby or within the array and verify it at runtime. In case it's missing we should report it in the crash report.
|
Assignee | |
Comment 1•2 years ago
|
||
|
||
Updated•2 years ago
|
Assignee: nobody → gsvelto
Status: NEW → ASSIGNED
Pushed by gsvelto@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/86e82f01df51
Verify that we found the annotation table when reading crash annotations r=KrisWright
|
||
Comment 3•2 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
status-firefox120:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 120 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•