1856383 - MV3: Origin controls displays "Always allow on [site]" instead of "On All Sites" when http(s) host permission is requested

Status: RESOLVED FIXED

(WebExtensions :: General, defect, P3)

Description

[Rob Wu [:robwu]]

With a Manifest Version 3 extension, Origin controls displays "Always allow on [site]" instead of "On All Sites" when the requested host permission is http://*/* or https://*/* (separately from *//*/* or <all_urls>). This is because the implementation relies on matchpatternset.subsumes(allDomains) with allDomains = new MatchPattern("*://*/*"): https://searchfox.org/mozilla-central/rev/95787423bc1c7ba895ef9c6918feb054866d9f41/toolkit/components/extensions/ExtensionPermissions.sys.mjs#560-562

And that in turns does not work due to bug 1856380.

Either bug 1856380 needs to be fixed, or the implementation linked above should use matchesAllWebUrls from part 1 of bug 1853409.

Minimal test case:

1. Load extension with following manifest.json:

{
  "name": "http-https-perm",
  "manfest_version": 3,
  "version": "1",
  "host_permissions": [ "http://*/*", "https://*/*" ]
}

2. Visit about:addons and grant the permission to all websites via the Permissions tab of the add-on ("Access your data for all websites").
3. Visit example.com
4. Click on the Extension Button.
5. Click on the cog next to the add-on and look at the menu item.

Expected (this can be seen if you use "host_permissions": ["*://*/*"] instead):

• "On All Sites"

Actual:

• "Always allow on example.com"

Comment 1

[Luca Greco [:rpl] [:luca] [:lgreco]]

Attachment: Bug 1856383 - origin control message should show on all sites on http(s) host permissions. r?robwu,zombie

Depends on D215147

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6e449c45ed4f
origin control message should show on all sites on http(s) host permissions. r=robwu,zombie

Comment 3

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/6e449c45ed4f