1856528 - [wpt-sync] Sync PR 42306 - Reland "[fetch-later] Force sending when BackgroundSync permission is off"

Status: RESOLVED FIXED

(Core :: DOM: Networking, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 42306 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/42306
Details from upstream follow.

Ming-Ying Chung <[e-mail]> wrote:

Reland "[fetch-later] Force sending when BackgroundSync permission is off"

This reverts commit 2e63732c1a8b8120630c8678f1443282be5bae59.

Reason for revert: Fixed broken WPT.

Original change's description:

Revert "[fetch-later] Force sending when BackgroundSync permission is off"

This reverts commit d32dc3635147aa9cb4638864865aa6f86f42f2f2.

Reason for revert:
Caused consistent failures for virtual/fetch-later/wpt_internal/fetch/fetch-later/send-on-deactivate-with-background-sync.tentative.https.window.html

https://ci.chromium.org/ui/p/chromium/builders/ci/Mac10.15%20Tests/42380/overview

Original change's description:

[fetch-later] Force sending when BackgroundSync permission is off

The privacy decision suggests: after user navigates away from
a page, any pending requests left in the page should not be sent
if BackgroundSync permission is off (default is on in Chrome).

This CL forces sending out deferred requests on entering
BackForwardCache if the page's BackgroundSync permission is off.

Bug: 1465781
Change-Id: I120fbbc13294c40fcf13162d5d786f97e2131367
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4845750
Reviewed-by: Nidhi Jaju \<[e-mail]>
Auto-Submit: Ming-Ying Chung \<[e-mail]>
Reviewed-by: Xianzhu Wang \<[e-mail]>
Reviewed-by: Adam Rice \<[e-mail]>
Commit-Queue: Xianzhu Wang \<[e-mail]>
Cr-Commit-Position: refs/heads/main@{#1204080}

Bug: 1465781
Change-Id: I09e342e97d52745610d751eb21ee694ccf24976c
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4908141
Reviewed-by: Cammie Smith Barnes \<[e-mail]>
Owners-Override: Cammie Smith Barnes \<[e-mail]>
Bot-Commit: Rubber Stamper \<[e-mail]>
Commit-Queue: Cammie Smith Barnes \<[e-mail]>
Auto-Submit: Jian Li \<[e-mail]>
Commit-Queue: Jian Li \<[e-mail]>
Cr-Commit-Position: refs/heads/main@{#1204260}

Bug: 1465781
Change-Id: I7abf6340a23066c0794e4d6010b5ce5ce64c8943

Reviewed-on: https://chromium-review.googlesource.com/4903454
WPT-Export-Revision: ca0be2d660362d8dce6eded9c03bc0d78ebd4a22

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

PR 42306 applied with additional changes from upstream: 5bd62ed6dee3fdb8fcdf35704203eb8e7eb410d2, 26d93762b77806b6623bfbcd9aed139d102c8f93, 34e3a8a6cd3df89182ceea8c7b6e34a2b41c57d2

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

PR 42306 applied with additional changes from upstream: c973f6fcbe7b1e8804dedd438ae2b1f1b364cb03, 0a1448724c308dcae68539e4debe137af083a51f

Comment 3

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=2aab539bb02f87979cb9034fce9a27debeeb5c24

Comment 4

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 0 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests

Status Summary

Firefox

ERROR: 1

Chrome

ERROR: 1

Safari

ERROR: 1

Links

GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

• /fetch/fetch-later/send-on-deactivate.tentative.https.window.html [wpt.fyi]: ERROR (Chrome: ERROR, Safari: ERROR)

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/81f32719c9dc
[wpt PR 42306] - Reland "[fetch-later] Force sending when BackgroundSync permission is off", a=testonly

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e6965cc7032b
[wpt PR 42306] - Reland "[fetch-later] Force sending when BackgroundSync permission is off", a=testonly

Comment 7

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/e6965cc7032b