1856545 - Try to utilize idle time more

Status: RESOLVED FIXED

(Core :: XPCOM, enhancement)

Description

[Olli Pettay [:smaug][[e-mail]]]

Right now idle detection is very conservative and doesn't let idle tasks to run as often as they could. This then forces for example GC and CC to rely on timers to get the slices run eventually.

Comment 1

[Olli Pettay [:smaug][[e-mail]]]

Attachment: Bug 1856545 - Try to utilize idle time more, r=farre

We can go through quite a few more timers these days, since timers are stored now in an array and iterating through that is fast.
Also, relying on timer value for another thread or low priority timers does prevent idle tasks to run in some cases, and now that more timers
are iterated through, that behavior can be removed.

For RefreshDriver this is taking the simple approach and just let idle tasks to run if RefreshDriver isn't ticking. We do start RefreshDriverTimer pretty
much always when something in DOM or layout is changing.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5873383c36e2
Try to utilize idle time more, r=farre

Comment 3

[Cristina Horotan [:chorotan]]

Backed out changeset 5873383c36e2 (Bug 1856545) for causing talos max run time exceeded failures.

Backout: https://hg.mozilla.org/integration/autoland/rev/461a9c98a535b9896e9d394bdfee72ce90cf7afd

Failure push: https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=5873383c36e2b661fe5df1eb25a0580357cb6a95&selectedTaskRun=BtV2fQCbToiriyPuOwNHRw.0

Failure log: https://treeherder.mozilla.org/logviewer?job_id=431522793&repo=autoland&lineNumber=1129

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/107265085a67
Try to utilize idle time more, r=farre

Comment 5

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/107265085a67

Comment 6

[Alexandru Ionescu (needinfo me) [:alexandrui]]

(In reply to Cristina Horotan [:chorotan] from comment #3)

Backed out changeset 5873383c36e2 (Bug 1856545) for causing talos max run time exceeded failures.

Backout: https://hg.mozilla.org/integration/autoland/rev/461a9c98a535b9896e9d394bdfee72ce90cf7afd

Failure push: https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=5873383c36e2b661fe5df1eb25a0580357cb6a95&selectedTaskRun=BtV2fQCbToiriyPuOwNHRw.0

Failure log: https://treeherder.mozilla.org/logviewer?job_id=431522793&repo=autoland&lineNumber=1129

== Change summary for alert #39838 (as of Sat, 07 Oct 2023 18:16:03 GMT) ==

Improvements:

Ratio	Test	Platform	Options	Absolute values (old vs new)	Performance Profiles
8%	google-mail LastVisualChange	linux1804-64-shippable-qr	fission warm webrender	1,496.68 -> 1,376.87	Before/After
5%	reddit fcp	linux1804-64-shippable-qr	cold fission webrender	219.55 -> 207.90

For up to date results, see: https://treeherder.mozilla.org/perfherder/alerts?id=39838