1856698 - Make adsEnabled and adsEnabledByUser the names of the props on the child actor, and have canFetchAndShowAds check both

Status: RESOLVED FIXED

(Firefox Graveyard :: Shopping, task, P3)

Description

[:Gijs (he/him)]

Renaming these would make it a bit clearer and allow simplifying some of the conditions to only check one thing (canFetchAndShowAds) rather than having to manually check both that and whether the user pref is also set to true.

Comment 1

[Jared Hirsch [:jhirsch] (he/him) (Needinfo please)]

Moving "fast follow" items to top-level in the shopping backlog. Apologies for bug spam

Comment 2

[kpatenio]

Attachment: Bug 1856698 - simplify ads props for shopping sidebar child actor

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4a249d62c87b
simplify ads props for shopping sidebar child actor r=shopping-reviewers,Gijs

Comment 4

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/4a249d62c87b

Comment 5

[BugBot [:suhaib / :marco/ :calixte]]

Since nightly and release are affected, beta will likely be affected too.
For more information, please visit BugBot documentation.

Comment 6

[(PTO June 19-July 7) Ryan VanderMeulen]

Does this need a Beta (and Release?) approval request?

Comment 7

[kpatenio]

(In reply to Ryan VanderMeulen [:RyanVM] from comment #6)

Does this need a Beta (and Release?) approval request?

Hi Ryan, this patch doesn't need to be uplifted. We'll let it ride the trains.