Closed Bug 1856699 Opened 2 years ago Closed 2 years ago

[wpt-sync] Sync PR 42319 - Make <selectlist>'s button toggle the listbox

Categories

(Core :: DOM: Core & HTML, task, P4)

Product:
Core
Component:
DOM: Core & HTML
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
121 Branch
Tracking Flags:
Tracking Status
firefox121 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

(Blocks 1 open bug,
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 42319 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/42319
Details from upstream follow.

Joey Arhar <jarhar@chromium.org> wrote:

Make <selectlist>'s button toggle the listbox

This patch makes the selectlist button click handler close the listbox
when it is open instead of just keeping it open or reopening it.

Fixed: 1408838
Change-Id: I95e5d1522d7f402261b22f201a690417b85302bc

Reviewed-on: https://chromium-review.googlesource.com/4908961
WPT-Export-Revision: 73051f1b77ab149ad1ee2baa9b2d3f24f3e05ff4

Component: web-platform-tests → DOM: Core & HTML
Product: Testing → Core

CI Results

Ran 8 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 6 tests and 2 subtests

Status Summary

Firefox

OK : 6
FAIL: 31

Chrome

OK : 6
PASS: 23
FAIL: 8

Safari

OK : 6
FAIL: 31

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

  • /html/semantics/forms/the-selectlist-element/selectlist-button-closes-listbox.tentative.html [wpt.fyi]
    • defaultbutton-defaultlistbox: Clicking the selectlist's button should toggle the listbox.: FAIL (Chrome: FAIL, Safari: FAIL)
    • custombutton-defaultlistbox: Clicking the selectlist's button should toggle the listbox.: FAIL (Chrome: FAIL, Safari: FAIL)
    • defaultbutton-customlistbox: Clicking the selectlist's button should toggle the listbox.: FAIL (Chrome: FAIL, Safari: FAIL)
    • custombutton-customlistbox: Clicking the selectlist's button should toggle the listbox.: FAIL (Chrome: FAIL, Safari: FAIL)
  • /html/semantics/forms/the-selectlist-element/selectlist-nested.tentative.html [wpt.fyi]
    • A <selectlist> shouldn't apply controller code to parts nested in a <selectlist> child: FAIL (Chrome: PASS, Safari: FAIL)
    • A <selectlist> shouldn't apply controller code to parts nested in a <select> child: FAIL (Chrome: PASS, Safari: FAIL)
    • A nested button part in a nested <selectlist> shouldn't get controller code even if it comes first in document order: FAIL (Chrome: PASS, Safari: FAIL)
  • /html/semantics/forms/the-selectlist-element/selectlist-parts-structure.tentative.html [wpt.fyi]
    • HTMLOptionElements (and not other element types) should receive option controller code: FAIL (Chrome: PASS, Safari: FAIL)
    • To receive option part controller code, an option must be a descendant of the listbox part in a flat tree traversal: FAIL (Chrome: PASS, Safari: FAIL)
    • To receive button part controller code, an element labeled as a button must not be a descendant of the listbox part in a flat tree traversal: FAIL (Chrome: FAIL, Safari: FAIL)
    • To receive listbox part controller code, an element labeled as a listbox must not be a descendant of the button part in a flat tree traversal: FAIL (Chrome: PASS, Safari: FAIL)
    • Button controller code should be applied in flat tree traversal order regardless of dynamic insertion order: FAIL (Chrome: FAIL, Safari: FAIL)
    • Listbox controller code should be applied in flat tree traversal order regardless of dynamic insertion order: FAIL (Chrome: PASS, Safari: FAIL)
    • selected-value controller code should be applied in flat tree traversal order regardless of dynamic insertion order: FAIL (Chrome: PASS, Safari: FAIL)
    • Ensure that option controller code is updated when listbox changes: FAIL (Chrome: PASS, Safari: FAIL)
    • Ensure that controller code is applied when slot and part attributes are different: FAIL (Chrome: PASS, Safari: FAIL)
    • Ensure that controller code is synchronously applied: FAIL (Chrome: FAIL, Safari: FAIL)
    • Controller code should be updated when nested parts are removed: FAIL (Chrome: FAIL, Safari: FAIL)
    • Moving a selectlist between documents should keep controller code active: FAIL (Chrome: PASS, Safari: FAIL)
    • New parts should be detected even when in the subtree of an inserted node: FAIL (Chrome: PASS, Safari: FAIL)
    • Part removals should be detected even when in the subtree of a removed node: FAIL (Chrome: PASS, Safari: FAIL)
  • /html/semantics/forms/the-selectlist-element/selectlist-popover-position-with-zoom.tentative.html [wpt.fyi]
    • The popover should be bottom left positioned: FAIL (Chrome: PASS, Safari: FAIL)
    • The popover should be top left positioned: FAIL (Chrome: PASS, Safari: FAIL)
    • The popover should be bottom right positioned: FAIL (Chrome: PASS, Safari: FAIL)
    • The popover should be top right positioned: FAIL (Chrome: PASS, Safari: FAIL)
  • /html/semantics/forms/the-selectlist-element/selectlist-popover.tentative.html [wpt.fyi]
    • Opening the popover and clicking an option should change the selectlist's value: FAIL (Chrome: PASS, Safari: FAIL)
    • With custom button and popover: opening the popover and clicking an option should change the selectlist's value: FAIL (Chrome: PASS, Safari: FAIL)
    • Clicking a popover with no listbox part does nothing: FAIL (Chrome: PASS, Safari: FAIL)
    • Clicking a popover with a listbox that was removed does nothing: FAIL (Chrome: PASS, Safari: FAIL)
  • /html/semantics/forms/the-selectlist-element/selectlist-pseudo-open-closed.tentative.html [wpt.fyi]
    • Selectlist should support :open and :closed pseudo selectors.: FAIL (Chrome: PASS, Safari: FAIL)
    • Selectlist :open and :closed should invalidate correctly.: FAIL (Chrome: PASS, Safari: FAIL)
Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/7d28102a7559 [wpt PR 42319] - Make <selectlist>'s button toggle the listbox, a=testonly https://hg.mozilla.org/integration/autoland/rev/79e348356998 [wpt PR 42319] - Update wpt metadata, a=testonly

https://hg.mozilla.org/mozilla-central/rev/7d28102a7559
https://hg.mozilla.org/mozilla-central/rev/79e348356998

Status: NEW → RESOLVED
Closed: 2 years ago
status-firefox121: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 121 Branch
You need to log in before you can comment on or make changes to this bug.