Closed Bug 1856736 Opened 1 year ago Closed 1 year ago

Revert group labels and result labels to their previous appearance for sponsored priority result

Categories

(Firefox :: Address Bar, task, P1)

task

Tracking

()

VERIFIED FIXED
120 Branch
Tracking Status
firefox119 --- verified
firefox120 --- verified

People

(Reporter: daisuke, Assigned: daisuke)

References

Details

Attachments

(2 files)

As the title said, need to revert both labels to their previous appearance.
Specifically, do the following.

  1. Group label: "Sponsored" to "Top pick"
  2. Result label: nothing to "Sponsored"
Assignee: nobody → daisuke
Status: NEW → ASSIGNED
Pushed by dakatsuka.birchill@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/c9c8d8e2def4 Revert group labels and result labels to their previous appearance r=adw
Severity: -- → N/A
Priority: -- → P1
Status: ASSIGNED → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → 120 Branch

Comment on attachment 9356480 [details]
Bug 1856736: Revert group labels and result labels to their previous appearance

Beta/Release Uplift Approval Request

  • User impact if declined: Our product team decided to change the group label and result label for the urlbar result of the sponsored suggestion. We expect the wording is best for the user.
  • Is this code covered by automated tests?: Yes
  • Has the fix been verified in Nightly?: No
  • Needs manual test from QE?: No
  • If yes, steps to reproduce:
  • List of other uplifts needed: None
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): This revision changes only the label appearance for the urlbar result of the priority sponsored suggestion.
  • String changes made/needed: None
  • Is Android affected?: No
Attachment #9356480 - Flags: approval-mozilla-beta?

I have verified this issue on the latest Firefox Nightly 120.0a1 (Build ID: 20231004155628) on Windows 10 x64, Ubuntu 20.04 x64, and macOS 12.6.1.

  • The group label is now displayed as “Top pick”, just above the website icon and keyword.
  • The result label is now displayed as “Sponsored”, right under the keyword and website row.

:daisuke there are merge conflicts in browser/components/urlbar/tests/quicksuggest/unit/test_quicksuggest.js with this patch in beta
This is caused by Bug 1854059.
Please attach a patch that graphs cleanly to beta.

Flags: needinfo?(daisuke)
Flags: needinfo?(daisuke)
Attachment #9356480 - Flags: approval-mozilla-beta?

Thanks, Donal! I made a new patch for Beta codebase. I will ask to uplift again now.

Comment on attachment 9356944 [details]
Bug 1856736: Revert group labels and result labels to their previous appearance (for Beta codebase)

Beta/Release Uplift Approval Request

  • User impact if declined: Our product team decided to change the group label and result label for the urlbar result of the sponsored suggestion. We expect the wording is best for the user.
  • Is this code covered by automated tests?: Yes
  • Has the fix been verified in Nightly?: Yes
  • Needs manual test from QE?: No
  • If yes, steps to reproduce:
  • List of other uplifts needed: None
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): This revision changes only the label appearance for the urlbar result of the priority sponsored suggestion.
  • String changes made/needed: None
  • Is Android affected?: No
Attachment #9356944 - Flags: approval-mozilla-beta?

Comment on attachment 9356944 [details]
Bug 1856736: Revert group labels and result labels to their previous appearance (for Beta codebase)

Approved for 119.0b7

Attachment #9356944 - Flags: approval-mozilla-beta? → approval-mozilla-beta+

I have verified this issue on the latest Firefox Beta 119.0b7 (Build ID: 20231009111645) on Windows 10 x64, Ubuntu 20.04 x64, and macOS 12.6.1.

  • The group label is now displayed as “Top pick”, just above the website icon and keyword.
  • The result label is now displayed as “Sponsored”, right under the keyword and website row.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: