Revert group labels and result labels to their previous appearance for sponsored priority result
Categories
(Firefox :: Address Bar, task, P1)
Tracking
()
People
(Reporter: daisuke, Assigned: daisuke)
References
Details
Attachments
(2 files)
48 bytes,
text/x-phabricator-request
|
Details | Review | |
48 bytes,
text/x-phabricator-request
|
dmeehan
:
approval-mozilla-beta+
|
Details | Review |
As the title said, need to revert both labels to their previous appearance.
Specifically, do the following.
- Group label: "Sponsored" to "Top pick"
- Result label: nothing to "Sponsored"
Assignee | ||
Comment 1•1 year ago
|
||
Updated•1 year ago
|
Updated•1 year ago
|
Comment 3•1 year ago
|
||
bugherder |
Assignee | ||
Comment 4•1 year ago
|
||
Comment on attachment 9356480 [details]
Bug 1856736: Revert group labels and result labels to their previous appearance
Beta/Release Uplift Approval Request
- User impact if declined: Our product team decided to change the group label and result label for the urlbar result of the sponsored suggestion. We expect the wording is best for the user.
- Is this code covered by automated tests?: Yes
- Has the fix been verified in Nightly?: No
- Needs manual test from QE?: No
- If yes, steps to reproduce:
- List of other uplifts needed: None
- Risk to taking this patch: Low
- Why is the change risky/not risky? (and alternatives if risky): This revision changes only the label appearance for the urlbar result of the priority sponsored suggestion.
- String changes made/needed: None
- Is Android affected?: No
Comment 5•1 year ago
|
||
I have verified this issue on the latest Firefox Nightly 120.0a1 (Build ID: 20231004155628) on Windows 10 x64, Ubuntu 20.04 x64, and macOS 12.6.1.
- The group label is now displayed as “Top pick”, just above the website icon and keyword.
- The result label is now displayed as “Sponsored”, right under the keyword and website row.
Comment 6•1 year ago
|
||
:daisuke there are merge conflicts in browser/components/urlbar/tests/quicksuggest/unit/test_quicksuggest.js
with this patch in beta
This is caused by Bug 1854059.
Please attach a patch that graphs cleanly to beta.
Assignee | ||
Comment 7•1 year ago
|
||
Assignee | ||
Updated•1 year ago
|
Assignee | ||
Comment 8•1 year ago
|
||
Thanks, Donal! I made a new patch for Beta codebase. I will ask to uplift again now.
Assignee | ||
Comment 9•1 year ago
|
||
Comment on attachment 9356944 [details]
Bug 1856736: Revert group labels and result labels to their previous appearance (for Beta codebase)
Beta/Release Uplift Approval Request
- User impact if declined: Our product team decided to change the group label and result label for the urlbar result of the sponsored suggestion. We expect the wording is best for the user.
- Is this code covered by automated tests?: Yes
- Has the fix been verified in Nightly?: Yes
- Needs manual test from QE?: No
- If yes, steps to reproduce:
- List of other uplifts needed: None
- Risk to taking this patch: Low
- Why is the change risky/not risky? (and alternatives if risky): This revision changes only the label appearance for the urlbar result of the priority sponsored suggestion.
- String changes made/needed: None
- Is Android affected?: No
Comment 10•1 year ago
|
||
Comment on attachment 9356944 [details]
Bug 1856736: Revert group labels and result labels to their previous appearance (for Beta codebase)
Approved for 119.0b7
Comment 11•1 year ago
|
||
uplift |
Updated•1 year ago
|
Comment 12•1 year ago
|
||
I have verified this issue on the latest Firefox Beta 119.0b7 (Build ID: 20231009111645) on Windows 10 x64, Ubuntu 20.04 x64, and macOS 12.6.1.
- The group label is now displayed as “Top pick”, just above the website icon and keyword.
- The result label is now displayed as “Sponsored”, right under the keyword and website row.
Description
•