1856740 - [wpt-sync] Sync PR 42233 - Make navigation-api/navigate-event/ resilient to starting with extra NavigationHistoryEntries

Status: RESOLVED FIXED

(Testing :: web-platform-tests, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 42233 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/42233
Details from upstream follow.

Nate Chapin <[e-mail]> wrote:

Make navigation-api/navigate-event/ resilient to starting with extra NavigationHistoryEntries

When WPT are run in-browser or via wptrunner, there may be additional
session history entries when the test starts, so the tests shouldn't
assume that they start with navigation.entries().length == 1 or
navigation.currentEntry.index == 0.

This is a workaround for https://github.com/web-platform-tests/wpt/issues/33590.

Change-Id: I978d492d5d31d110716d6a1d84732aff792aca14
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4904223
Reviewed-by: Domenic Denicola \<[e-mail]>
Auto-Submit: Nate Chapin \<[e-mail]>
Commit-Queue: Nate Chapin \<[e-mail]>
Cr-Commit-Position: refs/heads/main@{#1204863}

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=6267c6f8e6c373ecb3cc80e3a2c96942ce97da59

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 9 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 15 tests and 1 subtests

Status Summary

Firefox

OK : 15
FAIL : 15

Chrome

OK : 14
PASS : 12
FAIL : 3
ERROR: 1

Safari

OK : 15
FAIL : 15

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

• /navigation-api/navigate-event/intercept-and-navigate.html [wpt.fyi]
  • Using intercept() then navigate() in the ensuing currententrychange should abort the finished promise (but not the committed promise): FAIL (Chrome: PASS, Safari: FAIL)
• /navigation-api/navigate-event/intercept-navigation-back.html [wpt.fyi]
  • event.intercept() can intercept navigation.back(): FAIL (Chrome: PASS, Safari: FAIL)
• /navigation-api/navigate-event/intercept-same-document-history-back.html [wpt.fyi]
  • event.intercept() can intercept same-document history.back(): FAIL (Chrome: PASS, Safari: FAIL)
• /navigation-api/navigate-event/navigate-destination-dynamic-index.html [wpt.fyi]
  • navigate event destination.index should be dynamic: FAIL (Chrome: PASS, Safari: FAIL)
• /navigation-api/navigate-event/navigate-history-back-after-fragment.html [wpt.fyi]
  • history.back() fires the navigate event and sets hashChange when reversing a fragment navigation: FAIL (Chrome: FAIL, Safari: FAIL)
• /navigation-api/navigate-event/navigate-history-back-after-pushState.html [wpt.fyi]
  • history.back() fires the navigate event when reversing a pushState(): FAIL (Chrome: FAIL, Safari: FAIL)
• /navigation-api/navigate-event/navigate-history-back-noop.html [wpt.fyi]
  • history.back() does not fire a navigate event when there's nothing to navigate: FAIL (Chrome: PASS, Safari: FAIL)
• /navigation-api/navigate-event/navigate-navigation-back-same-document.html [wpt.fyi]
  • navigate event for navigation.back() - same-document: FAIL (Chrome: FAIL, Safari: FAIL)
• /navigation-api/navigate-event/navigation-back-same-document-preventDefault.html [wpt.fyi]
  • navigation.back() same-document preventDefault: FAIL (Chrome: PASS, Safari: FAIL)
• /navigation-api/navigate-event/navigation-traverseTo-in-iframe-same-document-preventDefault.html [wpt.fyi]
  • navigation.traverseTo() in an iframe with same-document preventDefault in its parent: FAIL (Chrome: PASS, Safari: FAIL)
• /navigation-api/navigate-event/navigation-traverseTo-navigates-top-and-same-doc-child-and-cross-doc-child.html [wpt.fyi]
  • navigation.traverseTo() can navigate 3 frames of different types with correct navigate event cancelable values: FAIL (Chrome: PASS, Safari: FAIL)
• /navigation-api/navigate-event/navigation-traverseTo-same-document-preventDefault-multiple-windows.html [wpt.fyi]
  • navigation.traverseTo() - if a top window cancels the traversal, any iframes should not fire navigate: FAIL (Chrome: PASS, Safari: FAIL)
• /navigation-api/navigate-event/navigation-traverseTo-top-cancels-cross-document-child.html [wpt.fyi]
  • navigate.traverseTo() cancelled by top frame cancels cross-document iframe: FAIL (Chrome: PASS, Safari: FAIL)
• /navigation-api/navigate-event/same-url-replace-cross-document.html [wpt.fyi]
  • navigate() to the current URL cross document should replace: FAIL (Chrome: PASS, Safari: FAIL)
• /navigation-api/navigate-event/same-url-replace-same-document.html [wpt.fyi]
  • navigate() to the current URL same document should replace: FAIL (Chrome: PASS, Safari: FAIL)

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0ffb634e43b9
[wpt PR 42233] - Make navigation-api/navigate-event/ resilient to starting with extra NavigationHistoryEntries, a=testonly

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c186ac4a11f4
[wpt PR 42233] - Make navigation-api/navigate-event/ resilient to starting with extra NavigationHistoryEntries, a=testonly

Comment 5

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/c186ac4a11f4