185676 - Back/Forward Buttons on MS IntelliMouse Moving Back/Forward Twice

Status: VERIFIED FIXED

(Core :: XUL, defect)

Description

[Rick Bull]

User-Agent:       Mozilla/5.0 (Windows; U; Win98; en-US; rv:1.3a) Gecko/20021212
Build Identifier: Mozilla/5.0 (Windows; U; Win98; en-US; rv:1.3a) Gecko/20021212

With this latest Alpha my back/forward buttons are making the page go
back/forward twice, where they only used to do it once. This exact same thing
happened in Opera 6.x where it was fine before. I think I have the latest
drivers, and disabling back/forward in the IntelliPoint control panel means I
loose the functionality altogether.

I posted this on MozillaZone too
(http://www.mozillazine.org/forums/viewtopic.php?p=18998) which WillyWonka came
up with an idea about.

Reproducible: Sometimes

Steps to Reproduce:
1. Press the back/forward button on the mouse (with a few pages of history)

Comment 1

[Chris Lyon]

Can you reproduce this problem with a new build of Mozilla and the latest
Intellipoint drivers?

>This exact same thing happened in Opera 6.x where it was fine before.

Doesn't sounds like a mozilla bug then...

Comment 2

[Ian Nartowicz]

I get this too, very frustrating.  Doesn't always happen but happens regularly
enough to be very annoying!  Still happening with build ID 2003010808.  Started
happening around 1.3a, hard to be sure.  Definitely didn't happen with 1.0.

I considered that my mouse might be freaking out, but what could the mouse
possibly be sending that Mozilla should go back two pages?

Anyway: Microsoft Intellimouse Optical, Win98.

Comment 3

[Rick Bull]

>Can you reproduce this problem with a new build of Mozilla and the latest
Intellipoint drivers?

I downloaded a nightly a day or two ago and it the problem still there.



>Doesn't sounds like a mozilla bug then...

But the problem doesn't seem to be there in Opera beta 7, unless the just
haven't implemeneted the InteliMouse drivers yet?



>...what could the mouse possibly be sending that Mozilla should go back two pages?

On MozillaZine forum WillyWonka said maybe Mozilla was detecting the back button
being pressed and changing the page, then the InteliMouse drivers were sending
Ctrl+Left and making the page go back again. Although I've actually had it go
back about 4/5 pages, which is REALLY annoying!

It is a bug that I think needs to be fixed - I find it so annoying that I've
gone back to 1.2.1.

Comment 4

[Yoni Gilad]

Attachment: patch

I've been having this problem too since 1.3a on win98: So I fixed it.

This patch causes the WM_APPCOMMAND handler from bug 30431 to return 1 to
notify the driver that the event was handled.

Comment 5

[Matthias Versen [:Matti]]

-> XP Toolkit

Comment 6

[:deanis74]

Comment on attachment 111360 [details] [diff] [review]
patch

Argh, I got result and aRetValue confused.  r=me

Comment 7

[timeless]

3.166 rods%netscape.com Jul 9, 1999
Commented out the setting of the return value in bottom of ProcessMessage 

Comment 8

[Christian :Biesinger (don't email me, ping me on IRC)]

this was checked in:
01/12/2003 20:10 timeless%mozdev.org mozilla/ widget/ src/ windows/ nsWindow.cpp
3.459 1/0  Bug 185676 Back/Forward Buttons on MS IntelliMouse Moving
Back/Forward Twice
patch by [e-mail] r=dean_tessman sr=bryner

should it be marked fixed?

Comment 9

[Matthias Versen [:Matti]]

-> fixed

Yoni Gilad: Thanks for the patch

Comment 10

[Ian Nartowicz]

Is this patch in build ID 2003011208?  I am still seeing the double movement,
but have also had a small window popup appear when I hit the back button.  The
title was "Alert", it was only a title bar with no window space, and only a
close control.

Comment 11

[Ian Nartowicz]

Looks good in 2003011405 (earlier nightly wouldn't install).  Thank god for
that, it was driving me nuts :)

Comment 12

[:deanis74]

Verified based on comment 11.

Comment 13

[Rick Bull]

Well the bug is still present in the latest nightly 2003010508, so it's either
not been added yet, or there's still something to be changed. Happens on both
back and forward.

Comment 14

[:deanis74]

2003010508 is not the latest nightly, it's from Jan 5 (0105).  The bug was fixed
on Jan 13.

Comment 15

[Rick Bull]

Whoops. Sorry about that, I must have opened the wrong file! You're right the
bug seems to have been cleared up. Thanks a lot Yoni.

Comment 16

[R.K.Aa.]

*** Bug 189742 has been marked as a duplicate of this bug. ***

Comment 17

[:deanis74]

*** Bug 195475 has been marked as a duplicate of this bug. ***

Comment 18

[Daniel Wang]

*** Bug 187495 has been marked as a duplicate of this bug. ***