Closed
Bug 185679
Opened 22 years ago
Closed 22 years ago
[AxPlugin] Plugin does not build when MOZ_OBJDIR is defined
Categories
(Core Graveyard :: Embedding: ActiveX Wrapper, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: adamlock, Assigned: adamlock)
Details
Attachments
(1 file)
|
664 bytes,
patch
|
dbradley
:
review+
netscape
:
superreview+
|
Details | Diff | Splinter Review |
The ActiveX plugin contains some files that #include "StdAfx.h". When MOZ_OBJDIR is defined, the compiler picks up a StdAfx.h in $(srcdir)\..\control\ in preference to the one in the plugins folder causing compile errors. Probably this is because the current directory is the obj dir and not the srcdir causing the wrong include path to take precedence. This is where $(srcdir)\..\control\ is added to LOCAL_INCLUDES http://lxr.mozilla.org/seamonkey/source/embedding/browser/activex/src/plugin/Makefile.in#139 The fix is to add -I$(srcdir) to here too. Patch follows.
|
||
Comment 2•22 years ago
|
||
Comment on attachment 109441 [details] [diff] [review] Patch r=dbradley Works fine now
Attachment #109441 -
Flags: review+
Comment on attachment 109441 [details] [diff] [review] Patch Chris can you r/sr this simple fix please?
Attachment #109441 -
Flags: superreview?(seawood)
|
||
Updated•22 years ago
|
Attachment #109441 -
Flags: superreview?(seawood) → superreview+
Fix is checked in
Status: NEW → RESOLVED
Closed: 22 years ago
Resolution: --- → FIXED
|
||
Updated•12 years ago
|
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•