[AxPlugin] Plugin does not build when MOZ_OBJDIR is defined

RESOLVED FIXED

Status

Core Graveyard
Embedding: ActiveX Wrapper
RESOLVED FIXED
15 years ago
6 years ago

People

(Reporter: Adam Lock, Assigned: Adam Lock)

Tracking

Trunk
x86
Windows 2000

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

664 bytes, patch
David Bradley
: review+
hacker formerly known as seawood@netscape.com
: superreview+
Details | Diff | Splinter Review
(Assignee)

Description

15 years ago
The ActiveX plugin contains some files that #include "StdAfx.h". When MOZ_OBJDIR
is defined, the compiler picks up a StdAfx.h in $(srcdir)\..\control\ in
preference to the one in the plugins folder causing compile errors. Probably
this is because the current directory is the obj dir and not the srcdir causing
the wrong include path to take precedence.

This is where $(srcdir)\..\control\ is added to LOCAL_INCLUDES

http://lxr.mozilla.org/seamonkey/source/embedding/browser/activex/src/plugin/Makefile.in#139

The fix is to add -I$(srcdir) to here too. Patch follows.
(Assignee)

Comment 1

15 years ago
Created attachment 109441 [details] [diff] [review]
Patch

Comment 2

15 years ago
Comment on attachment 109441 [details] [diff] [review]
Patch

r=dbradley

Works fine now
Attachment #109441 - Flags: review+
(Assignee)

Comment 3

15 years ago
Comment on attachment 109441 [details] [diff] [review]
Patch

Chris can you r/sr this simple fix please?
Attachment #109441 - Flags: superreview?(seawood)
Attachment #109441 - Flags: superreview?(seawood) → superreview+
(Assignee)

Comment 4

15 years ago
Fix is checked in
Status: NEW → RESOLVED
Last Resolved: 15 years ago
Resolution: --- → FIXED
Component: Embedding: ActiveX Wrapper → Embedding: ActiveX Wrapper
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.