1856899 - Make the annotation reader use fallible allocations and cap the size of the annotations

Status: NEW

(Toolkit :: Crash Reporting, enhancement)

Description

[Gabriele Svelto [:gsvelto]]

Bug 1854179 highlighted why we shouldn't trust the data coming from a crashed child process. Bugs or even an attacker might manipulate the child memory to cause disproportionately large memory allocations in the main process, while it is reading the child's annotations.

The fix for bug 1854179 capped the number of allocations we retrieve, but there's no cap on the size of the individual annotations and all their allocations are currently infallible.

We should enforce a global cap so as not to read too much data from the child process (which we wouldn't be able to submit to Socorro anyway) and make the relevant allocations fallible to protect us from crashing the main process.