Closed
Bug 1856910
Opened 3 years ago
Closed 3 years ago
Optimize code for JS string comparisons in C++ a bit
Categories
(Core :: JavaScript Engine, task)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
120 Branch
| Tracking | Status | |
|---|---|---|
| firefox120 | --- | fixed |
People
(Reporter: jandem, Assigned: jandem)
References
(Blocks 1 open bug)
Details
(Whiteboard: [sp3])
Attachments
(2 files)
No description provided.
|
Assignee | |
Updated•3 years ago
|
Blocks: speedometer3
Whiteboard: [sp3]
|
||
Updated•3 years ago
|
See Also: → https://mozilla-hub.atlassian.net/browse/SP3-594
|
|
Assignee | |
Comment 1•3 years ago
|
||
This matches the fast path we have in JIT code.
|
|
Assignee | |
Comment 2•3 years ago
|
||
This bypasses some checks that are redundant with the fast paths all callers use in JIT code.
Depends on D190019
Pushed by jdemooij@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/0196de790c52
part 1 - Check for atoms in js::EqualSrings. r=iain
https://hg.mozilla.org/integration/autoland/rev/c0fa8dd831d4
part 2 - Call EqualChars directly in jit::StringsEqual. r=iain
|
||
Comment 4•3 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/0196de790c52
https://hg.mozilla.org/mozilla-central/rev/c0fa8dd831d4
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
status-firefox120:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 120 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•