1856931 - Bookmarks are not displayed as an option for importing when using the –migration command and importing from Firefox

Status: NEW

(Firefox :: Migration, defect, P3)

Description

[Alexandru Trif, Desktop Test Engineering [:atrif]]

Attachment: image.png

Found in

• 119.0b4

Affected versions

• 120.0a1 (2023-10-02)
• 119.0b4
• 118.0.1

Tested platforms

• Affected platforms: Ubuntu 18, macOS 11, Windows 10x64
• Unaffected platforms: none

Preconditions

• have some bookmarks saved in a Firefox profile

Steps to reproduce

1. Open Firefox with the --migration command.
2. Select the Firefox profile from preconditions.

Expected result

• The Bookmarks option is displayed for importing.

Actual result

• The Bookmarks option is not displayed for importing.

Regression

• Most likely started after the implementation of bug 1854243.

Additional notes

• Aattached a screenshot.
• Bookmarks are correctly imported even if there is no indication of that.
• On the old migration window Browsing History and Booksmarks are displayed together. On the new one only Browsing History is displayed.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

:mconley, since you are the author of the regressor, bug 1823537, could you take a look?

For more information, please visit BugBot documentation.

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1823537

Comment 3

[Mike Conley (:mconley) (:⚙️)]

Looking into this, this is because the FirefoxProfileMigrator can't differentiate between bookmarks and history - they're both the same database - so it can only copy over the whole thing, or none of it. So what we used to do is change the label of the resource to be "Browsing History and Bookmarks" if a Firefox profile is being migrated from. We should probably do the same here.

Comment 4

[Mike Conley (:mconley) (:⚙️)]

flod, am I remembering correctly that this pattern is to be discouraged, and was really meant to be more for platforms or quantities? Or am I misremembering?

Comment 5

[Francesco Lodolo [:flod]]

Yes, it's discouraged (no guarantee each locale will maintain all variants you need)
https://firefox-source-docs.mozilla.org/l10n/fluent/review.html#variants-and-plurals