1856932 - Update googletest to new version 2dd1c131950043a8ad5ab0d2dda0e0970596586a from 2023-10-05

Status: RESOLVED FIXED

(Testing :: GTest, enhancement)

Description

[Update Bot]

This update covers 4 commits. Here are the overall diff statistics, and then the commit information.

---

third_party/googletest/CMakeLists.txt | 2 +-
third_party/googletest/googlemock/CMakeLists.txt | 20 ++--
third_party/googletest/googlemock/include/gmock/gmock-function-mocker.h | 9 +-
third_party/googletest/googletest/CMakeLists.txt | 26 +++---
third_party/googletest/googletest/cmake/internal_utils.cmake | 36 +++++-----
third_party/googletest/googletest/include/gtest/gtest.h | 4 +-
third_party/googletest/googletest/include/gtest/internal/gtest-port.h | 4 +-
third_party/googletest/moz.yaml | 4 +-
8 files changed, 52 insertions(+), 53 deletions(-)

---

beb552fb47e9e8a6ddab20526663c2dddd601ec6 by Dino Radakovic

https://github.com/google/googletest/commit/beb552fb47e9e8a6ddab20526663c2dddd601ec6
Authored: 2023-10-03 11:41:17 -0700
Committed: 2023-10-03 11:41:48 -0700

gmock_cook_book: Document DoAll's return type requirement

The requirement is vaguely documented by "Only the return value of the last action in the sequence will be used.".
However, this can be misleading, as users could potentially expect default-constructed values to be returned in absence of a matching return type.

PiperOrigin-RevId: 570450839
Change-Id: Ibd98a6e6b2aaf2a8cfc15ed6aeab442526eab98e

Files Modified:

• docs/gmock_cook_book.md

---

2d09ed35cfabc8032545a401e883aafd3efda048 by Dzmitry Ivaniuk

https://github.com/google/googletest/commit/2d09ed35cfabc8032545a401e883aafd3efda048
Authored: 2023-09-29 17:26:23 +0300
Committed: 2023-09-29 17:26:23 +0300

cmake: Fix comments in cmake files

Remove extra spaces. Fix so that the comment line starts with a capital letter and ends with a dot.

Files Modified:

• CMakeLists.txt
• googlemock/CMakeLists.txt
• googletest/CMakeLists.txt
• googletest/cmake/internal_utils.cmake

---

e47544ad31cb3ceecd04cc13e8fe556f8df9fe0b by Abseil Team

https://github.com/google/googletest/commit/e47544ad31cb3ceecd04cc13e8fe556f8df9fe0b
Authored: 2023-09-25 14:37:34 -0700
Committed: 2023-09-25 14:38:01 -0700

Resolve -Wundef triggering on GTEST_CREATE_SHARED_LIBRARY and GTEST_LINKED_AS_SHARED_LIBRARY with shared libraries in GoogleTest

Fixes: #4372
PiperOrigin-RevId: 568327612
Change-Id: Ifc47f1a2a2648c29858a22966331557cc928cc47

Files Modified:

• googletest/include/gtest/internal/gtest-port.h

---

e27b194c2702f02cf033a32bb49978b8ff32aa15 by Mitja Spes

https://github.com/google/googletest/commit/e27b194c2702f02cf033a32bb49978b8ff32aa15
Authored: 2023-09-21 10:06:21 +0200
Committed: 2023-09-21 10:06:21 +0200

Fix compile warnings in gmock-function-mocker.h

Template type int changed to size_t.
This fixes compile warning conversion to ‘long unsigned int’ from ‘int’ may change the sign of the result in gmock-function-mocker.h.

Files Modified:

• googlemock/include/gmock/gmock-function-mocker.h

---

Comment 1

[Update Bot]

I've submitted a try run for this commit: https://treeherder.mozilla.org/jobs?repo=try&revision=48378d40ffbbd5564f3448485b1462865f6b4c3a

Comment 2

[Update Bot]

Updatebot encountered an error while trying to submit to phabricator.
Updatebot will be unable to do anything more for this library version.

Comment 3

[Andrew Halberstadt [:ahal]]

Any idea what happened here? I haven't setup/used updatebot before.

Comment 4

[Tom Ritter [:tjr] (OOTO until April)]

Sorry, it looks like it's hit this bug: https://github.com/mozilla-services/updatebot/issues/322

The try run succeeded, if you run the following commands locally you can re-create the patches, and then submit them to phab yourself.

./mach vendor third_party/googletest/moz.yaml --revision beb552fb47e9e8a6ddab20526663c2dddd601ec6 --patch-mode none
./mach vendor --patch-mode only third_party/googletest/moz.yaml

Comment 5

[Chris Peterson [:cpeterson]]

Green try auto:

https://treeherder.mozilla.org/jobs?repo=try&revision=3127dabb66ae0021f081a514309e75ebacb85cdb

Comment 6

[Chris Peterson [:cpeterson]]

Attachment: Bug 1856932 - Update googletest to 2dd1c131950043a8ad5ab0d2dda0e0970596586a. r?ahal

Comment 7

[Chris Peterson [:cpeterson]]

Attachment: Bug 1856932 - Apply local patches to googletest. r?ahal

Depends on D190255

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3839f9f99de2
Update googletest to 2dd1c131950043a8ad5ab0d2dda0e0970596586a. r=ahal
https://hg.mozilla.org/integration/autoland/rev/9379db61b716
Apply local patches to googletest. r=ahal

Comment 9

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/3839f9f99de2
https://hg.mozilla.org/mozilla-central/rev/9379db61b716