Closed Bug 1856976 Opened 1 year ago Closed 1 year ago

[wpt-sync] Sync PR 42335 - Update mutation event suppression for <details name> to revised spec rules.

Categories

(Core :: DOM: Core & HTML, task, P4)

task

Tracking

()

RESOLVED FIXED
121 Branch
Tracking Status
firefox121 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 42335 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/42335
Details from upstream follow.

L. David Baron <dbaron@chromium.org> wrote:

Update mutation event suppression for <details name> to revised spec rules.

The rules for mutation event suppression for \<details name> were revised
during the process of reviewing the spec PR, based on the discussion
starting at
https://github.com/whatwg/html/pull/9400#discussion_r1340856291 . The
updated spec says that mutation events are suppressed during the "ensure
details exclusivity by closing other elements if needed" and "ensure
details exclusivity by closing the given element if needed" algorithms.
This updates the implementation and tests to follow that rule. (The
"handling of insertion of elements into group" test is testing the case
where the events were already suppressed.)

This also renames the test to remove "tentative" from the name, since
the spec PR is landed and the test is now (with this change) up-to-date
with the spec.

Bug: 1444057
Change-Id: I9078beeb3527f2515f6e10efbf93a94232221238
Reviewed-on: https://chromium-review.googlesource.com/4912273
WPT-Export-Revision: 36dc73e4f34f11c622fb2968b3e19ac9aeac0169

Component: web-platform-tests → DOM: Core & HTML
Product: Testing → Core

CI Results

Ran 8 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests and 17 subtests

Status Summary

Firefox

OK : 1
PASS : 1
FAIL : 16

Chrome

OK : 1
PASS : 13
FAIL : 4

Safari

PASS : 11
FAIL : 5
TIMEOUT: 2

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

Firefox-only Failures

  • /html/semantics/interactive-elements/the-details-element/name-attribute.html [wpt.fyi]
    • basic handling of mutually exclusive details: FAIL
    • mutually exclusive details across multiple names and multiple tree scopes: FAIL
    • exclusivity enforcement with attachment scenario connected: FAIL
    • exclusivity enforcement with attachment scenario disconnected: FAIL
    • exclusivity enforcement with attachment scenario shadow: FAIL
    • exclusivity enforcement with attachment scenario shadow-in-disconnected: FAIL
    • exclusivity enforcement with attachment scenario template-in-disconnected: FAIL
    • exclusivity enforcement with attachment scenario connected-in-xhr-response: FAIL
    • exclusivity enforcement with attachment scenario connected-in-implementation-create-document: FAIL
    • exclusivity enforcement with attachment scenario connected-in-template: FAIL

New Tests That Don't Pass

  • /html/semantics/interactive-elements/the-details-element/name-attribute.html [wpt.fyi]
    • basic handling of mutually exclusive details: FAIL (Chrome: PASS, Safari: PASS)
    • more complex handling of mutually exclusive details: FAIL (Chrome: PASS, Safari: FAIL)
    • mutually exclusive details across multiple names and multiple tree scopes: FAIL (Chrome: PASS, Safari: PASS)
    • mutation event and toggle event order: FAIL (Chrome: FAIL, Safari: FAIL)
    • interaction of open attribute changes with mutation events: FAIL (Chrome: FAIL, Safari: FAIL)
    • exclusivity enforcement with attachment scenario connected: FAIL (Chrome: PASS, Safari: PASS)
    • exclusivity enforcement with attachment scenario disconnected: FAIL (Chrome: PASS, Safari: PASS)
    • exclusivity enforcement with attachment scenario shadow: FAIL (Chrome: PASS, Safari: PASS)
    • exclusivity enforcement with attachment scenario shadow-in-disconnected: FAIL (Chrome: PASS, Safari: PASS)
    • exclusivity enforcement with attachment scenario template-in-disconnected: FAIL (Chrome: PASS, Safari: PASS)
    • exclusivity enforcement with attachment scenario connected-in-xhr-response: FAIL (Chrome: PASS, Safari: PASS)
    • exclusivity enforcement with attachment scenario connected-in-implementation-create-document: FAIL (Chrome: PASS, Safari: PASS)
    • exclusivity enforcement with attachment scenario connected-in-template: FAIL (Chrome: PASS, Safari: PASS)
    • handling of name attribute changes: FAIL (Chrome: FAIL, Safari: FAIL)
    • closing as a result of parsing doesn't depend on attribute order: FAIL (Chrome: PASS, Safari: FAIL)
    • handling of insertion of elements into group: FAIL (Chrome: FAIL, Safari: TIMEOUT)
Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/79aff7d6f240 [wpt PR 42335] - Update mutation event suppression for <details name> to revised spec rules., a=testonly https://hg.mozilla.org/integration/autoland/rev/a995d6a9d2b6 [wpt PR 42335] - Update wpt metadata, a=testonly
Status: NEW → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → 121 Branch
You need to log in before you can comment on or make changes to this bug.