Closed Bug 185698 Opened 22 years ago Closed 22 years ago

localeVersion update for 1.3b on trunk

Categories

(Core :: Internationalization: Localization, defect)

Product:
Core
Component:
Internationalization: Localization
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED

People

(Reporter: kairo, Assigned: rchen)

References

Details

Attachments

(2 files)

patch: change all localeVersions, as well as brand.dtd/region.dtd to 1.3b
55.53 KB, patch
tao
: review+
blizzard
: superreview+
Details | Diff | Splinter Review
additional cosmetic patch to change the missed but unneeded files of dl manager
2.25 KB, patch
rchen
: review+
blizzard
: superreview+
dbaron
: approval1.3b+
Details | Diff | Splinter Review 
localeVersion is still 1.2 on trunk, even was that in the 1.3a release. We
should at least have the correct one on 1.3b again...
Flags: blocking1.3b?
Don't know if it is belongs to localization or not though...
CC'ing Tao who might have more insight on this.
BTW, the last bug of this style was bug 175853, which was fixed by... er... me!

Anyway, if anyone comes up with a patch before I do, I'm quite happy with that
as I don't have much time currently...
Leaf has the script. In the past, this was taken care of along with the release
version string change.

Hi, Ray: you can dig out similar bugs from previous releases to get a quick patch.
is this can be considered as a dup of bug 151932?
yxia:
this is no dupe as the big checkin still has to happen for each version
seperately, and as leaf missed it for the last release (1.3a), it doesn't look
that he thinks to run the script automatically.

Ideally, we would only have to flip one variable somewhere and the build process
would set the right localeVersion strings according to that, but we're not in
that ideal world :(
Flags: blocking1.3b? → blocking1.3b+
OK, here's the patch for this issue. It's good to have helpful tools sometimes
:)

I discovered that phoenix (mozilla/browser) still has a strange mix of 0.9.9
and 1.1b localeVersions - but I guess I shouldn't change phoenix files, right?
;-)
Comment on attachment 110413 [details] [diff] [review]
patch: change all localeVersions, as well as brand.dtd/region.dtd to 1.3b

jbetak, can you review this patch? it's a simple localeVersion change...
Attachment #110413 - Flags: review?(jbetak)
jbetak@netscape.com is not around.
Tao, do you have time to review this?
Comment on attachment 110413 [details] [diff] [review]
patch: change all localeVersions, as well as brand.dtd/region.dtd to 1.3b

looks right.
Attachment #110413 - Flags: review?(jbetak) → review+
Note that the commercial trunk needs a similar patch.
Attachment #110413 - Flags: superreview?(blizzard)
tao:
True, commercial might need that as well. I don't have access to commercial
though and can't provide patches for that. Sorry.
Comment on attachment 110413 [details] [diff] [review]
patch: change all localeVersions, as well as brand.dtd/region.dtd to 1.3b

rs=blizzard
Attachment #110413 - Flags: superreview?(blizzard) → superreview+
OK, checked in the patch. Should be fixed.

For reference (if anyone sees problems), touched the following 77 files:

mozilla/xpfe/communicator/resources/content/contents-region.rdf
mozilla/xpfe/communicator/resources/content/contents-platform.rdf
mozilla/xpfe/communicator/resources/content/contents.rdf
mozilla/xpfe/communicator/resources/locale/en-US/mac/contents-platform.rdf
mozilla/xpfe/communicator/resources/locale/en-US/win/contents-platform.rdf
mozilla/xpfe/communicator/resources/locale/en-US/unix/contents-platform.rdf
mozilla/xpfe/communicator/resources/locale/en-US/contents-region.rdf
mozilla/xpfe/communicator/resources/locale/en-US/contents.rdf
mozilla/xpfe/components/prefwindow/resources/locale/en-US/mac/contents-platform.rdf
mozilla/xpfe/components/prefwindow/resources/locale/en-US/win/contents-platform.rdf
mozilla/xpfe/components/prefwindow/resources/locale/en-US/unix/contents-platform.rdf
mozilla/xpfe/components/autocomplete/resources/locale/en-US/contents.rdf
mozilla/xpfe/components/download-manager/resources/mac/contents.rdf
mozilla/xpfe/global/resources/content/contents-region.rdf
mozilla/xpfe/global/resources/content/contents-platform.rdf
mozilla/xpfe/global/resources/content/contents.rdf
mozilla/xpfe/global/resources/locale/en-US/mac/contents-platform.rdf
mozilla/xpfe/global/resources/locale/en-US/os2/contents-platform.rdf
mozilla/xpfe/global/resources/locale/en-US/win/contents-platform.rdf
mozilla/xpfe/global/resources/locale/en-US/unix/contents-platform.rdf
mozilla/xpfe/global/resources/locale/en-US/contents-region.rdf
mozilla/xpfe/global/resources/locale/en-US/contents.rdf
mozilla/xpfe/browser/resources/content/mac/contents-platform.rdf
mozilla/xpfe/browser/resources/content/win/contents-platform.rdf
mozilla/xpfe/browser/resources/content/unix/contents-platform.rdf
mozilla/xpfe/browser/resources/content/contents-region.rdf
mozilla/xpfe/browser/resources/content/contents.rdf
mozilla/xpfe/browser/resources/locale/en-US/mac/contents-platform.rdf
mozilla/xpfe/browser/resources/locale/en-US/win/contents-platform.rdf
mozilla/xpfe/browser/resources/locale/en-US/unix/contents-platform.rdf
mozilla/xpfe/browser/resources/locale/en-US/contents-region.rdf
mozilla/xpfe/browser/resources/locale/en-US/contents.rdf
mozilla/mailnews/base/resources/content/contents-region.rdf
mozilla/mailnews/base/resources/content/contents.rdf
mozilla/mailnews/base/resources/locale/en-US/contents-region.rdf
mozilla/mailnews/base/resources/locale/en-US/contents.rdf
mozilla/mailnews/mapi/resources/content/contents.rdf
mozilla/mailnews/mapi/resources/locale/en-US/contents.rdf
mozilla/mailnews/extensions/mdn/resources/content/contents.rdf
mozilla/mailnews/extensions/mdn/resources/locale/en-US/contents.rdf
mozilla/mailnews/extensions/smime/resources/content/contents.rdf
mozilla/mailnews/extensions/smime/resources/locale/en-US/contents.rdf
mozilla/mailnews/extensions/smoketest/resources/content/contents.rdf
mozilla/mailnews/extensions/mailviews/resources/content/contents.rdf
mozilla/editor/ui/composer/content/contents-region.rdf
mozilla/editor/ui/composer/content/contents.rdf
mozilla/editor/ui/composer/locale/en-US/contents-region.rdf
mozilla/editor/ui/composer/locale/en-US/contents.rdf
mozilla/netwerk/resources/content/contents.rdf
mozilla/netwerk/resources/locale/en-US/contents.rdf
mozilla/security/manager/pki/resources/content/contents.rdf
mozilla/security/manager/pki/resources/locale/en-US/contents.rdf
mozilla/security/manager/ssl/resources/content/contents.rdf
mozilla/security/manager/ssl/resources/locale/en-US/contents.rdf
mozilla/layout/html/forms/resources/locale/en-US/contents.rdf
mozilla/extensions/irc/xul/content/contents.rdf
mozilla/extensions/irc/xul/locale/en-US/contents.rdf
mozilla/extensions/help/resources/content/contents.rdf
mozilla/extensions/help/resources/locale/en-US/contents.rdf
mozilla/extensions/pref/autoconfig/resources/content/contents.rdf
mozilla/extensions/pref/autoconfig/resources/locale/en-US/contents.rdf
mozilla/extensions/cookie/resources/content/contents.rdf
mozilla/extensions/cookie/resources/locale/en-US/contents.rdf
mozilla/extensions/editor/cascades/resources/locale/en-US/contents.rdf
mozilla/extensions/venkman/resources/content/contents.rdf
mozilla/extensions/venkman/resources/locale/en-US/contents.rdf
mozilla/extensions/wallet/resources/content/contents.rdf
mozilla/extensions/wallet/resources/locale/en-US/contents.rdf
mozilla/extensions/content-packs/resources/content/contents.rdf
mozilla/extensions/content-packs/resources/locale/en-US/contents.rdf
mozilla/extensions/inspector/resources/content/contents.rdf
mozilla/extensions/inspector/resources/locale/en-US/contents.rdf
mozilla/extensions/transformiix/resources/contents.rdf
mozilla/directory/xpcom/base/resources/content/contents.rdf
mozilla/directory/xpcom/base/resources/locale/en-US/contents.rdf
mozilla/xpfe/global/resources/locale/en-US/brand.dtd
mozilla/xpfe/global/resources/locale/en-US/region.dtd
Status: NEW → RESOLVED
Closed: 22 years ago
Resolution: --- → FIXED
man, I long for bug 154927 getting fixed...
I'll go fix the ns tree.  (It might be causing today's ns blocker)
It looks like the following files were missed:
mozilla/xpfe/components/download-manager/resources/unix/contents.rdf
mozilla/xpfe/components/download-manager/resources/win/contents.rdf
dbaron:
hmm, strange that my script didn't catch those. they aren't used though, and I
believe it's a mistake they're there at all... chrome registry uses
communicator/contents.rdf for everything in communicator/, also for dl manager.

I'll post a cosmetic patch that changes those two files as well - but I think we
should remove them completely, as well as the one for mac.
OK, this patch does the cosmetic to change those two files as well. As already
stated, the files aren't even needed...
Comment on attachment 113747 [details] [diff] [review]
additional cosmetic patch to change the missed but unneeded files of dl manager

I don't dare to reopen the bug, as it's marked as a 1.3b blocker...
Requesting r=/sr= though.
This patch corrects two missed files, which aren't used by chrome registry so
they don't have a real impact...
Attachment #113747 - Flags: superreview?(blizzard)
Attachment #113747 - Flags: review?(tao)
I'm not so sure they're unused, since I found them (the unix one, anyway) by
looking at the localeVersion lines in my chrome/chrome.rdf.
Hi, Robert:

Could you please ask rchen to review the patch? Ray is the current module owner.

thx
Comment on attachment 113747 [details] [diff] [review]
additional cosmetic patch to change the missed but unneeded files of dl manager

sr=blizzard
Attachment #113747 - Flags: superreview?(blizzard) → superreview+
Comment on attachment 113747 [details] [diff] [review]
additional cosmetic patch to change the missed but unneeded files of dl manager

I am surprised to see the problem still exist.

Leaf, didn't we plan to centralize localeVersion to one place? How is the
progress? We can't keep doing like this.

r=rchen
Attachment #113747 - Flags: review?(tao) → review+
Checking in mozilla/xpfe/components/download-manager/resources/unix/contents.rdf;
/cvsroot/mozilla/xpfe/components/download-manager/resources/unix/contents.rdf,v
 <--  contents.rdf
new revision: 1.2; previous revision: 1.1
done
Checking in mozilla/xpfe/components/download-manager/resources/win/contents.rdf;
/cvsroot/mozilla/xpfe/components/download-manager/resources/win/contents.rdf,v 
<--  contents.rdf
new revision: 1.2; previous revision: 1.1
done

OK, those two should be fixed as well now.
rchen:
BTW, the automated version of this is bug 154927 - we really need this soon, IMHO...
Depends on: 154927
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: