1857082 - Update AndroidX Activity to version 1.9.1

Status: RESOLVED FIXED

(Firefox for Android :: General, task, P2)

Description

[Ryan VanderMeulen [:RyanVM]]

Changelog:

• https://developer.android.com/jetpack/androidx/releases/activity#1.8.0

Comment 1

[Ryan VanderMeulen [:RyanVM]]

This is currently blocked on build failures:

fenix/app/src/main/java/org/mozilla/fenix/HomeActivity.kt:749: Error: Overriding method should call super.onBackPressed [MissingSuperCall]
    final override fun onBackPressed() {
                       ~~~~~~~~~~~~~

   Explanation for issues of type "MissingSuperCall":
   Some methods, such as View#onDetachedFromWindow, require that you also call
   the super implementation as part of your method.

Comment 2

[Ryan VanderMeulen [:RyanVM]]

v1.8.1 changelog: https://developer.android.com/jetpack/androidx/releases/activity#1.8.1

Comment 3

[Ryan VanderMeulen [:RyanVM]]

v1.8.2 changelog: https://developer.android.com/jetpack/androidx/releases/activity#1.8.2

Comment 4

[Ryan VanderMeulen [:RyanVM]]

v1.9.0 changelog: https://developer.android.com/jetpack/androidx/releases/activity#1.9.0

Comment 5

[Ryan VanderMeulen [:RyanVM]]

v1.9.1 changelog: https://developer.android.com/jetpack/androidx/releases/activity#1.9.1

Comment 6

[Petru-Mugurel Lingurar [:petru]]

Regarding the build failure it seems like onBackPressed is deprecated and we should use either
OnBackPressedDispatcher with OnBackPressedCallback that would get us backwards compatibility with Android API level 13+
OnBackPressedDispatcher with registerOnBackInvokedCallback with Android API level 33+ (in combination with the OnBackPressedCallback for lower versions).

The change does seem a bit (more) bigger 😕
Seeing that this hasn't been updated in >10 months and we're preparing to support Android 15 we should probably also migrate to the new API as part of that Android 15 effort.

Comment 7

[Ryan VanderMeulen [:RyanVM]]

Green on Try: https://treeherder.mozilla.org/jobs?repo=try&group_state=expanded&revision=262e0286f3c270f5aa13181da53ab9655fba8c17

Comment 8

[Ryan VanderMeulen [:RyanVM]]

Attachment: Bug 1857082 - Update AndroidX Activity to version 1.9.1.

Comment 9

[Ryan VanderMeulen [:RyanVM]]

Attachment: Bug 1857082 - Add suppressions for deprecated override warnings.

Comment 10

[Ryan VanderMeulen [:RyanVM]]

Attachment: Bug 1857082 - Remove safe call since uriList cannot be null.

Comment 11

[Ryan VanderMeulen [:RyanVM]]

Attachment: Bug 1857082 - Update onNewIntent override to account for intent nullability changes.

Comment 12

[Ryan VanderMeulen [:RyanVM]]

Attachment: Bug 1857082 - Suppress warning for missing onBackPressed() super call.

Comment 13

[Ryan VanderMeulen [:RyanVM]]

Attachment: Bug 1857082 - Suppress parameter naming warning.

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/dda549ed3150
Update AndroidX Activity to version 1.9.1. r=android-reviewers,mcarare
https://hg.mozilla.org/integration/autoland/rev/54c373d56a0b
Add suppressions for deprecated override warnings. r=android-reviewers,mcarare
https://hg.mozilla.org/integration/autoland/rev/d78b4758bd00
Remove safe call since uriList cannot be null. r=android-reviewers,mcarare
https://hg.mozilla.org/integration/autoland/rev/f3d15e1c3576
Update onNewIntent override to account for intent nullability changes. r=android-reviewers,mcarare
https://hg.mozilla.org/integration/autoland/rev/cd96e32d5251
Suppress warning for missing onBackPressed() super call. r=android-reviewers,mcarare
https://hg.mozilla.org/integration/autoland/rev/bdb714d9a12f
Suppress parameter naming warning. r=android-reviewers,mcarare

Comment 15

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/dda549ed3150
https://hg.mozilla.org/mozilla-central/rev/54c373d56a0b
https://hg.mozilla.org/mozilla-central/rev/d78b4758bd00
https://hg.mozilla.org/mozilla-central/rev/f3d15e1c3576
https://hg.mozilla.org/mozilla-central/rev/cd96e32d5251
https://hg.mozilla.org/mozilla-central/rev/bdb714d9a12f