1857260 - Improve macOS theme with titlebar on

Status: RESOLVED FIXED

(Firefox :: Theme, defect)

Description

[Emilio Cobos Álvarez [:emilio]]

Right now we use the native dialog background rather than the custom colors.

Comment 1

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 1857260 - More explicitly use custom colors for the toolbox. r=dao

Right now we were relying on the OS colors
(-moz-dialog/-moz-dialogtext/ActiveCaption/CaptionText).

The titlebar ones did the right thing but -moz-dialog and co didn't.

This caused two issues:

• With the titlebar checkbox on, we'd use the system colors even
  without prefers-contrast. This is specially noticeable on macOS.

• With prefers-contrast. We used -moz-dialog for the background and the
  toolbar on macOS. This caused little contrast.

Support the -moz-headerbar colors in all desktop platforms, and use
those on Linux + HCM, and use browser-custom-colors on Windows / macOS
to override the toolbox background explicitly to fix it.

This setup is a little bit more consistent with all other colors.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/296779994fe0
More explicitly use custom colors for the toolbox. r=dao,desktop-theme-reviewers,win-reviewers,mhowell

Comment 3

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/296779994fe0