Closed Bug 1857384 Opened 2 years ago Closed 2 years ago

[wpt-sync] Sync PR 42382 - Fix the dom-parts-api-2 benchmark to use declarative syntax

Categories

(Core :: DOM: Core & HTML, task, P4)

Product:
Core
Component:
DOM: Core & HTML
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
121 Branch
Tracking Flags:
Tracking Status
firefox121 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 42382 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/42382
Details from upstream follow.

Mason Freed <masonf@chromium.org> wrote:

Fix the dom-parts-api-2 benchmark to use declarative syntax

This uses the new declarative syntax for 3 of 4 parts, the exception
being the text node for which we don't have support in the new
syntax. This also goes back to using getParts() instead of the
temporary getPartNode() function.

In the process of doing this, I discovered crbug.com/1490375, so
I also added a test for that.

No functional changes.

Bug: 1490375,1453291
Change-Id: Ic2fd63312eb250915a1786165630c496b4b59d38
Reviewed-on: https://chromium-review.googlesource.com/4918550
WPT-Export-Revision: f8b334ca98d4b52002fdc4825e4c2a4ad3b47494

PR 42382 applied with additional changes from upstream: 5cdb13a85ebc46aca9d65ceff121acd99db502c7
Component: web-platform-tests → DOM: Core & HTML
Product: Testing → Core

CI Results

Ran 0 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests and 9 subtests

Status Summary

Firefox

OK : 1
FAIL: 9

Chrome

OK : 1
PASS: 6
FAIL: 3

Safari

OK : 1
FAIL: 9

Links

GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

  • /dom/parts/basic-dom-part-declarative-brace-syntax-innerhtml.tentative.html [wpt.fyi]
    • Declarative DOM Parts innerHTML <div><h1>content... (expect no parts): FAIL (Chrome: PASS, Safari: FAIL)
    • Declarative DOM Parts innerHTML <div><h1 parseparts>content... (expect no parts): FAIL (Chrome: PASS, Safari: FAIL)
    • Declarative DOM Parts innerHTML <div parseparts=""><h1>content... (expect no parts): FAIL (Chrome: PASS, Safari: FAIL)
    • Declarative DOM Parts innerHTML <div parseparts=""><h1 parseparts>content... (expect no parts): FAIL (Chrome: PASS, Safari: FAIL)
    • Declarative DOM Parts innerHTML <template><h1>content... (expect no parts): FAIL (Chrome: PASS, Safari: FAIL)
    • Declarative DOM Parts innerHTML <template><h1 parseparts>content... (expect no parts): FAIL (Chrome: PASS, Safari: FAIL)
    • Declarative DOM Parts innerHTML <template parseparts="" class="expect_success"><h1>content... (expect parts): FAIL (Chrome: FAIL, Safari: FAIL)
    • Declarative DOM Parts innerHTML <template parseparts="" class="expect_success"><h1 parseparts>content... (expect parts): FAIL (Chrome: FAIL, Safari: FAIL)
    • Basic NodePart parsing: FAIL (Chrome: FAIL, Safari: FAIL)
Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/9be47d92e113 [wpt PR 42382] - Fix the dom-parts-api-2 benchmark to use declarative syntax, a=testonly https://hg.mozilla.org/integration/autoland/rev/636891cee884 [wpt PR 42382] - Update wpt metadata, a=testonly

https://hg.mozilla.org/mozilla-central/rev/9be47d92e113
https://hg.mozilla.org/mozilla-central/rev/636891cee884

Status: NEW → RESOLVED
Closed: 2 years ago
status-firefox121: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 121 Branch
You need to log in before you can comment on or make changes to this bug.