Closed Bug 1857475 Opened 2 years ago Closed 2 years ago

Firefox desktop file claims DBusActivatable but can never be because of its name

Categories

(Firefox :: File Handling, defect)

Product:
Firefox
Component:
File Handling
Version:
Firefox 118
Type:
defect

Tracking

()

Status:
RESOLVED WORKSFORME

People

(Reporter: firefox, Unassigned)

Details

Steps to reproduce:

Downstream report https://bugs.kde.org/show_bug.cgi?id=475266

Firefox claims it is dbus activatable (DBusActivatable=true in the desktop file), but trying to activate can never work.

Actual results:

Firefox has DBusActivatable=true in its desktop file (firefox.desktop) according to the spec https://specifications.freedesktop.org/desktop-entry-spec/desktop-entry-spec-latest.html#dbus

Quoting:
The application must name its desktop file in accordance with the naming recommendations in the introduction section (e.g. the filename must be like org.example.FooViewer.desktop). The application must have a D-Bus service activatable at the well-known name that is equal to the desktop file name with the .desktop portion removed (for our example, org.example.FooViewer).

So when trying to activate firefox one makes a call to the service "firefox" however according to the dbus spec (https://dbus.freedesktop.org/doc/dbus-specification.html#message-protocol-names):

  • Bus names are composed of 1 or more elements separated by a period ('.') character.
    [...]
  • Bus names must contain at least one '.' (period) character (and thus at least two elements).

Since the name "firefox" has no period, the sender will hit an assert in libdbus.

Expected results:

Firefox should follow the spec either by removing DBusActivatable=true or renaming the desktpo file.

The Bugbug bot thinks this bug should belong to the 'Firefox::File Handling' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.

Component: Untriaged → File Handling

It appears that this issue was fixed on the KDE side. Could you confirm that this issue no longer occurs?
Thank you for your contribution!

Flags: needinfo?(firefox)

Yes I thought this file was coming from firefox but it seems to be a fedora issue. In addition we also no guard for broken files.

Flags: needinfo?(firefox)
Status: UNCONFIRMED → RESOLVED
Closed: 2 years ago
Resolution: --- → WORKSFORME
You need to log in before you can comment on or make changes to this bug.