1857585 - Clean up for table row and table cell code

Status: RESOLVED FIXED

(Core :: Layout: Tables, task)

Description

[Ting-Yu Lin [:TYLin] (PST, UTC-7)]

The bug collects the cleanup patches written while I'm reading table fragmentation code. None of the patches changes behavior.

Comment 1

[Ting-Yu Lin [:TYLin] (PST, UTC-7)]

Attachment: Bug 1857585 Part 1 - Remove unused PresContext parameter. r?#layout

Comment 2

[Ting-Yu Lin [:TYLin] (PST, UTC-7)]

Attachment: Bug 1857585 Part 2 - Remove a redundant writing-mode variable. r?#layout

wm has been declared near the beginning of nsTableCellFrame::Reflow().

Depends on D190371

Comment 3

[Ting-Yu Lin [:TYLin] (PST, UTC-7)]

Attachment: Bug 1857585 Part 3 - Remove nscoord parameter for ResetBSize(). r?#layout

It is confusing for ResetBSize() to take a parameter to set the fixed
block-size. The caller can call SetFixedBSize() if needed.

Depends on D190372

Comment 4

[Ting-Yu Lin [:TYLin] (PST, UTC-7)]

Attachment: Bug 1857585 Part 4 - Simplify unpaginated block-size helpers. r?#layout

We don't ever remove NS_TABLE_ROW_HAS_UNPAGINATED_BSIZE bit, so let's set the
bit directly in SetUnpaginatedBSize().

This patch doesn't change behavior.

Depends on D190373

Comment 5

[Ting-Yu Lin [:TYLin] (PST, UTC-7)]

Attachment: Bug 1857585 Part 5 - Use GetFirstCell() to avoid extra do_QueryFrame. r?#layout

nsTableRowFrame's children are all nsTableCellFrame, and GetFirstCell() has an
assertion for that. Hence, we can delete the unreachable code dealing with
non-cell frames.

Depends on D190374

Comment 6

[Ting-Yu Lin [:TYLin] (PST, UTC-7)]

Attachment: Bug 1857585 Part 6 - Use GetFirstRow() to avoid extra do_QueryFrame. r?#layout

While I'm here, revise GetFirstRow(), GetLastRow(), and GetNextRow(), and add
assertions to them to ensure the correctness of table frame tree structure.

Depends on D190375

Comment 7

[Ting-Yu Lin [:TYLin] (PST, UTC-7)]

Attachment: Bug 1857585 Part 7 - Revise the helper computing table cell's block-size. r?#layout

• It used to return useless nsresult. Change it to return the block-size
  instead of modifying the argument to return value.
• Shorten its name to CalcCellActualBSize. to match CalcBSize.

Depends on D190376

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/26cd8108386b
Part 1 - Remove unused PresContext parameter. r=dholbert
https://hg.mozilla.org/integration/autoland/rev/bb38442c5c66
Part 2 - Remove a redundant writing-mode variable. r=dholbert
https://hg.mozilla.org/integration/autoland/rev/33292b37979d
Part 3 - Remove nscoord parameter for ResetBSize(). r=dholbert
https://hg.mozilla.org/integration/autoland/rev/9b16e698bb50
Part 4 - Simplify unpaginated block-size helpers. r=dholbert
https://hg.mozilla.org/integration/autoland/rev/e3bac061baef
Part 5 - Use GetFirstCell() to avoid extra do_QueryFrame. r=dholbert
https://hg.mozilla.org/integration/autoland/rev/f419ded2ab03
Part 6 - Use GetFirstRow() to avoid extra do_QueryFrame. r=dholbert
https://hg.mozilla.org/integration/autoland/rev/8d59db268cc8
Part 7 - Revise the helper computing table cell's block-size. r=dholbert

Comment 9

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/26cd8108386b
https://hg.mozilla.org/mozilla-central/rev/bb38442c5c66
https://hg.mozilla.org/mozilla-central/rev/33292b37979d
https://hg.mozilla.org/mozilla-central/rev/9b16e698bb50
https://hg.mozilla.org/mozilla-central/rev/e3bac061baef
https://hg.mozilla.org/mozilla-central/rev/f419ded2ab03
https://hg.mozilla.org/mozilla-central/rev/8d59db268cc8