1857593 - Enable GPC in Private Browsing Mode by default

Status: RESOLVED FIXED

(Core :: Privacy: Anti-Tracking, enhancement, P3)

Description

[Benjamin VanderSloot [:bvandersloot]]

Just got word we can do this!

Comment 1

[Benjamin VanderSloot [:bvandersloot]]

Attachment: Bug 1857593 - Enable GPC in Private Browsing Mode by default - r=jewilde!,#anti-tracking!

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/44247957cb7a
Enable GPC in Private Browsing Mode by default - r=jewilde,anti-tracking-reviewers,necko-reviewers,valentin,timhuang

Comment 3

[Iulian Moraru]

Backed out for causing build bustages on nsHttpChannel.cpp.

• Push with failures

• Failure log

• Backout link

[task 2023-10-18T12:31:30.423Z] 12:31:30     INFO -  gmake[4]: Entering directory '/builds/worker/workspace/obj-build/netwerk/protocol/http'
[task 2023-10-18T12:31:30.423Z] 12:31:30     INFO -  /builds/worker/fetches/sccache/sccache /builds/worker/fetches/clang/bin/clang++ --target=x86_64-linux-android21 -o Unified_cpp_protocol_http4.o -c  -I/builds/worker/workspace/obj-build/dist/stl_wrappers -I/builds/worker/workspace/obj-build/dist/system_wrappers -include /builds/worker/checkouts/gecko/config/gcc_hidden.h -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -fstack-protector-strong -fstack-clash-protection -ftrivial-auto-var-init=pattern -DDEBUG=1 -DMOZ_HAS_MOZGLUE -DMOZILLA_INTERNAL_API -DIMPL_LIBXUL -DSTATIC_EXPORTABLE_JS_API -I/builds/worker/checkouts/gecko/netwerk/protocol/http -I/builds/worker/workspace/obj-build/netwerk/protocol/http -I/builds/worker/workspace/obj-build/ipc/ipdl/_ipdlheaders -I/builds/worker/checkouts/gecko/ipc/chromium/src -I/builds/worker/checkouts/gecko/dom/base -I/builds/worker/checkouts/gecko/netwerk/base -I/builds/worker/checkouts/gecko/netwerk/cookie -I/builds/worker/checkouts/gecko/netwerk/dns -I/builds/worker/checkouts/gecko/netwerk/ipc -I/builds/worker/checkouts/gecko/netwerk/socket/neqo_glue -I/builds/worker/checkouts/gecko/netwerk/url-classifier -I/builds/worker/checkouts/gecko/extensions/auth -I/builds/worker/workspace/obj-build/dist/include -I/builds/worker/workspace/obj-build/dist/include/nspr -I/builds/worker/workspace/obj-build/dist/include/nss -DMOZILLA_CLIENT -include /builds/worker/workspace/obj-build/mozilla-config.h --sysroot=/builds/worker/fetches/android-ndk/toolchains/llvm/prebuilt/linux-x86_64/sysroot --gcc-toolchain=/builds/worker/fetches/android-ndk/toolchains/llvm/prebuilt/linux-x86_64 -fno-sized-deallocation -fno-aligned-new -fno-short-enums -fcrash-diagnostics-dir=/builds/worker/artifacts -fno-exceptions -fPIC -fno-rtti -ffunction-sections -fdata-sections -fno-exceptions -fno-math-errno -pipe -gdwarf-4 -Xclang -load -Xclang /builds/worker/workspace/obj-build/build/clang-plugin/libclang-plugin.so -Xclang -add-plugin -Xclang moz-check -Oz -mno-outline -fno-omit-frame-pointer -funwind-tables -Werror -Wall -Wbitfield-enum-conversion -Wdeprecated-this-capture -Wempty-body -Wformat-type-confusion -Wignored-qualifiers -Wpointer-arith -Wshadow-field-in-constructor-modified -Wsign-compare -Wtautological-constant-in-range-compare -Wtype-limits -Wno-error=tautological-type-limit-compare -Wunreachable-code -Wunreachable-code-return -Wunused-but-set-parameter -Wno-invalid-offsetof -Wclass-varargs -Wempty-init-stmt -Wfloat-overflow-conversion -Wfloat-zero-conversion -Wloop-analysis -Wno-range-loop-analysis -Wc++2a-compat -Wenum-compare-conditional -Wenum-float-conversion -Wno-error=deprecated -Wno-error=deprecated-anon-enum-enum-conversion -Wno-error=deprecated-enum-enum-conversion -Wno-error=deprecated-pragma -Wno-error=deprecated-this-capture -Wcomma -Wimplicit-fallthrough -Wstring-conversion -Wno-inline-new-delete -Wno-error=deprecated-declarations -Wno-error=array-bounds -Wno-error=free-nonheap-object -Wno-error=atomic-alignment -Wno-error=deprecated-builtins -Wformat -Wformat-security -Wno-psabi -Wthread-safety -Wno-error=builtin-macro-redefined -Wno-unknown-warning-option -fno-strict-aliasing -ffp-contract=off  -MD -MP -MF .deps/Unified_cpp_protocol_http4.o.pp   Unified_cpp_protocol_http4.cpp
[task 2023-10-18T12:31:30.423Z] 12:31:30     INFO -  In file included from Unified_cpp_protocol_http4.cpp:47:
[task 2023-10-18T12:31:30.423Z] 12:31:30    ERROR -  /builds/worker/checkouts/gecko/netwerk/protocol/http/nsHttpChannel.cpp:9464:67: error: '&&' within '||' [-Werror,-Wlogical-op-parentheses]
[task 2023-10-18T12:31:30.423Z] 12:31:30     INFO -   9463 |       (StaticPrefs::privacy_globalprivacycontrol_enabled() ||
[task 2023-10-18T12:31:30.423Z] 12:31:30     INFO -        |                                                            ~~
[task 2023-10-18T12:31:30.423Z] 12:31:30     INFO -   9464 |        StaticPrefs::privacy_globalprivacycontrol_pbmode_enabled() &&
[task 2023-10-18T12:31:30.423Z] 12:31:30     INFO -        |        ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~
[task 2023-10-18T12:31:30.423Z] 12:31:30     INFO -   9465 |            NS_UsePrivateBrowsing(this))) {
[task 2023-10-18T12:31:30.423Z] 12:31:30     INFO -        |            ~~~~~~~~~~~~~~~~~~~~~~~~~~~
[task 2023-10-18T12:31:30.424Z] 12:31:30     INFO -  /builds/worker/checkouts/gecko/netwerk/protocol/http/nsHttpChannel.cpp:9464:67: note: place parentheses around the '&&' expression to silence this warning
[task 2023-10-18T12:31:30.424Z] 12:31:30     INFO -   9464 |        StaticPrefs::privacy_globalprivacycontrol_pbmode_enabled() &&
[task 2023-10-18T12:31:30.424Z] 12:31:30     INFO -        |                                                                   ^
[task 2023-10-18T12:31:30.424Z] 12:31:30     INFO -        |        (
[task 2023-10-18T12:31:30.424Z] 12:31:30     INFO -   9465 |            NS_UsePrivateBrowsing(this))) {
[task 2023-10-18T12:31:30.424Z] 12:31:30     INFO -        |
[task 2023-10-18T12:31:30.424Z] 12:31:30     INFO -        |                                       )
[task 2023-10-18T12:31:30.424Z] 12:31:30     INFO -  1 error generated.
[task 2023-10-18T12:31:30.424Z] 12:31:30    ERROR -  gmake[4]: *** [/builds/worker/checkouts/gecko/config/rules.mk:688: Unified_cpp_protocol_http4.o] Error 1
[task 2023-10-18T12:31:30.425Z] 12:31:30     INFO -  gmake[4]: Leaving directory '/builds/worker/workspace/obj-build/netwerk/protocol/http'

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a79933487604
Enable GPC in Private Browsing Mode by default - r=jewilde,anti-tracking-reviewers,necko-reviewers,valentin,timhuang

Comment 5

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/a79933487604