Closed Bug 1857798 Opened 1 year ago Closed 11 months ago

Perma [tier 2] /html/user-activation/navigation-state-reset-crossorigin.sub.html | Post-navigation state reset. - Test timed out

Categories

(Core :: DOM: Core & HTML, defect)

defect

Tracking

()

RESOLVED FIXED
121 Branch
Tracking Status
firefox-esr115 --- unaffected
firefox118 --- unaffected
firefox119 --- unaffected
firefox120 --- wontfix
firefox121 --- fixed

People

(Reporter: intermittent-bug-filer, Assigned: canadahonk)

References

(Regression)

Details

(Keywords: intermittent-failure, intermittent-testcase, regression, Whiteboard: [stockwell unknown])

Attachments

(2 files)

Filed by: ncsoregi [at] mozilla.com
Parsed log: https://treeherder.mozilla.org/logviewer?job_id=431744391&repo=mozilla-central
Full log: https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/P0qqNHGeS0OxSzwQI7AOJw/runs/0/artifacts/public/logs/live_backing.log


[task 2023-10-08T12:18:43.369Z] 12:18:43     INFO - TEST-START | /html/user-activation/navigation-state-reset-crossorigin.sub.html
[task 2023-10-08T12:18:43.375Z] 12:18:43     INFO - Closing window cf9652a3-389a-4395-9dc4-965f537e1824
[task 2023-10-08T12:18:46.263Z] 12:18:46     INFO - 
[task 2023-10-08T12:18:46.263Z] 12:18:46     INFO - TEST-UNEXPECTED-TIMEOUT | /html/user-activation/navigation-state-reset-crossorigin.sub.html | Post-navigation state reset. - Test timed out
[task 2023-10-08T12:18:46.263Z] 12:18:46     INFO - TEST-TIMEOUT | /html/user-activation/navigation-state-reset-crossorigin.sub.html | took 2896ms
[task 2023-10-08T12:18:46.267Z] 12:18:46     INFO - PID 26663 | 1696767526266	Marionette	INFO	Stopped listening on port 43156
[task 2023-10-08T12:18:46.716Z] 12:18:46     INFO - PID 26663 | console.error: ({})
[task 2023-10-08T12:18:46.898Z] 12:18:46     INFO - Browser exited with return code 0

Seems to be caused by Bug 1791079.
Oliver, can you take a look please?
Thank you.

Flags: needinfo?(omedhurst)

Set release status flags based on info from the regressing bug 1791079

I know Chromium has this flaky as well so I am pretty sure the test itself just is. I'll mark it as so.

Assignee: nobody → omedhurst
Status: NEW → ASSIGNED
Flags: needinfo?(omedhurst)

These tests can generally be flaky (Chromium experiences the same issues)

Marked as [..., TIMEOUT, NOTRUN]

FYI Patch also updates the tests Henrik posted, not just this bug's singular.

Is there an upstream bug filed on making the tests less flaky?

Not afaik. Chromium bug 1, Chromium bug 2 for reference.

Hi Oliver, following Peter's comment 8, I think it's worthwhile doing a bit further investigation to see what's up in the test cases themselves, or at minimum, we should file an upstream bug for this. Also, while interop-2024 selection process isn't done, https://github.com/web-platform-tests/interop/issues/428 receives lots of interests and Safari folks are fixing some testing failures. So having an upstream issue, may help the selection and the scoping.

Found this WPT GH issue on it generally, but it was closed as fixed last year but still flaky in both Gecko and Chromium. I'll open a new one referencing it.

Pushed by omedhurst@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/8145c0b27aa4 Mark user activation WPTs as flaky r=dom-core,edgar
Status: ASSIGNED → RESOLVED
Closed: 11 months ago
Resolution: --- → FIXED
Target Milestone: --- → 120 Branch

This is still happening as seen here

Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Target Milestone: 120 Branch → ---
Flags: needinfo?(omedhurst)
Regressions: 1860197

There were still intermittent fails in opt/release.

Submitted new patch to mark as flaky for non-debug too.

Flags: needinfo?(omedhurst)

(In reply to Oliver Medhurst [:canadahonk] from comment #19)

Submitted new patch to mark as flaky for non-debug too.

They don't fail on debug, the problem from the beginning was that there are some subtests that don't have specific expectations.
These should be it: https://hg.mozilla.org/try/rev/57b39b848b270b5701551bdf260dfd234db465db
Latest patch won't get rid of those failures.

Unfortunately when testing that try rev I've encountered a bug in the wpt harness: https://treeherder.mozilla.org/logviewer?job_id=433339386&repo=try, filed Bug 1860642.

Flags: needinfo?(omedhurst)

So I wonder if this is caused by the format error, could you try if

 [navigation-state-reset-crossorigin.sub.html]
   # There is a webdriver bug (Bug 1856989) which breaks cross-process iframe clicks
   bug: https://github.com/web-platform-tests/wpt/issues/42629
   expected:
     if fission: TIMEOUT
     if not debug: [OK, TIMEOUT, NOTRUN] # Flaky (Bug 1857798)

works?

Flags: needinfo?(csabou)

(In reply to Edgar Chen [:edgar] (OOO ~ 10/29) from comment #21)

So I wonder if this is caused by the format error, could you try if

 [navigation-state-reset-crossorigin.sub.html]
   # There is a webdriver bug (Bug 1856989) which breaks cross-process iframe clicks
   bug: https://github.com/web-platform-tests/wpt/issues/42629
   expected:
     if fission: TIMEOUT
     if not debug: [OK, TIMEOUT, NOTRUN] # Flaky (Bug 1857798)

works?

Looks like neither updates do not work.
https://hg.mozilla.org/try/rev/1639314b2237c4b772fd5598f35e37f6a93eb918 still has these failures https://treeherder.mozilla.org/logviewer?job_id=433503496&repo=try - try push

https://hg.mozilla.org/try/rev/f6594c1fa840831f03f505e796a492a34ad44e55 still has timeouts in navigation-state-reset-crossorigin.sub.html | Post-navigation state reset. and propagation-same-and-cross-origin.sub.html | Clicking on the cross-origin navigable activates parent navigable even though their expectation is set to TIMEOUT. https://treeherder.mozilla.org/logviewer?job_id=433488674&repo=try - try push
at least in this latter case the one set to NOTRUN (propagation-crossorigin.sub.html | Propagation test ) is gone.
The only thing I can think of for the other two that timeout is disabling because any other expectation does not seem to work.

Okay, so it seems we still need to mark some sub-test properly, I think the patch in comment#22 doesn't work because of the lack of . at the end of sub-test name, https://searchfox.org/mozilla-central/rev/e4afef5d3ff67781dc1377912344694f3cf3a226/testing/web-platform/tests/html/user-activation/navigation-state-reset-crossorigin.sub.html#50?

Yes, the dot is necessary. Otherwise the sub test name doesn't match and the entry is ignored.

Set release status flags based on info from the regressing bug 1791079

Attachment #9359772 - Attachment description: Bug 1857798 - Mark user activation WPTs as flaky for non-debug too → Bug 1857798 - Mark user activation WPTs as generally flaky

Changed patch to just generally mark them as flaky, as it seems more reasonable then trying to take into account various scenarios. We can always restrict later, better to just fix now imo.

Flags: needinfo?(omedhurst)

Patch for this bug is needed to fix unexpected pass.

Flags: needinfo?(omedhurst)
Attachment #9359772 - Attachment description: Bug 1857798 - Mark user activation WPTs as generally flaky → Bug 1857798 - Mark user activation WPTs as passing for fission off
Pushed by omedhurst@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/db619dbaec0a Mark user activation WPTs as passing for fission off r=dom-core,edgar
Status: REOPENED → RESOLVED
Closed: 11 months ago11 months ago
Resolution: --- → FIXED
Target Milestone: --- → 121 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: