Open Bug 1857859 Opened 2 years ago Updated 1 year ago

Toolbar "forward" button no longer respects inline/attachment setting - it's always fwd inline and another button is available for forward as attachment

Categories

(Thunderbird :: Toolbars and Tabs, defect)

Thunderbird 115
defect

Tracking

(Not tracked)

UNCONFIRMED

People

(Reporter: ossman, Unassigned)

Details

(Keywords: regression)

Steps to reproduce:

  1. Change "Composition" => "Forward messages" to "As Attachment"
  2. Click "Forward" button on toolbar

Actual results:

Message was forwarded inline

Expected results:

Message was forwarded as an attachment

I'm fairly certain this is a regression when upgrading to Thunderbird 115.

The "Forward" entry on the context menu still respects the setting properly, as does the toolbar on individual messages. So this bug seems to be just the main window toolbar.

I notice the tooltip for the "Forward" button is "Forward selected message as inline text", so this change was perhaps intentional?

There is another toolbar button for forwarding as an attachment, but it has a lot more text on it, and the toolbar is crowded as is.

Component: Untriaged → Toolbars and Tabs
Keywords: regression
Summary: Toolbar "forward" button no longer respects inline/attachment setting [regression] → Toolbar "forward" button no longer respects inline/attachment setting - it's always fwd inline and another button is available for forward as attachment

TCW can you reproduce?

Flags: needinfo?(thee.chicago.wolf)

(In reply to Wayne Mery (:wsmwk) from comment #2)

TCW can you reproduce?

I cannot repro this with the RC build of 115.8.0. My STR:

  1. Go to Tools > Settings > Composition > set Forward Messages: As Attachment
  2. Click on any email in your Inbox
  3. In the Message Pane's toolbar, click Forward

Expected Results: The message body + header is attached as an .eml file

Actual results: The message body + header is attached as an .eml file

However, I observe something else not good happening whilst in the above configuration when the email being forwarded already has an attachment: data loss. I have opened bug 1880754 for that issue.

Flags: needinfo?(thee.chicago.wolf)

(In reply to Pierre Ossman from comment #1)

I'm fairly certain this is a regression when upgrading to Thunderbird 115.

The "Forward" entry on the context menu still respects the setting properly, as does the toolbar on individual messages. So this bug seems to be just the main window toolbar.

I notice the tooltip for the "Forward" button is "Forward selected message as inline text", so this change was perhaps intentional?

There is another toolbar button for forwarding as an attachment, but it has a lot more text on it, and the toolbar is crowded as is.

Using the context menu "Forward" still works ok for me per Comment 3.

Pierre,

If TB 115.8.0 is released on Tuesday, can you try updating to it and then report back to see if it still happens? Nothing in the 115.8.0 Release Notes states any "Forwarding" issues like this one were fixed.

I get Thunderbird from my distribution (Fedora), but I can keep an eye out for an update and see if it resolves the issue here as well.

Sorry for the delay. I've now tested TB 115.8.0.

It is still broken, I'm afraid. :/

Works:

  • "Forward" in message pane toolbar
  • "Forward" in context menu

Doesn't work:

  • "Forward" from window top toolbar

This is currently the expected behavior. We split the two actions into discrete buttons. I do agree that it's suboptimal that only one has a longer label and that they still share the same icon.

That is extremely confusing IMO. "Forward" is available in five¹ different places. Four of them respect the setting. One does not. Hardly an intuitive user experience.

The short-term fix would probably be to rename the current "Forward" button to "Forward Inline", to clearly indicate that it does not respect the user setting.

Long term, a fix might be to add a third button that behaves like all other undecorated instances of "Forward".

Given that the functionality already exists in another toolbar, hopefully that is not too complex to hook up?

¹ Top toolbar, message toolbar, context menu, main menu, keyboard shortcut

You need to log in before you can comment on or make changes to this bug.