1857923 - "Error in parser worker" errors from CalICSService.jsm are missing useful information.

Status: RESOLVED FIXED

(Calendar :: Internal Components, defect)

Description

[Magnus Melin [:mkmelin]]

For invalid ics data we log things like this to the console:

Calendar: [CalICSService] Error in parser worker: [object Object] CalICSService.jsm:592
Calendar: Error Parsing ICS: 2147500037 CalIcsParser.jsm:145

This is kind of useless, as it should say what the problem is.
I'm going to fix this to make debugging more straight forwards.

Comment 1

[Magnus Melin [:mkmelin]]

Attachment: Bug 1857923 - Improve ICS parsing error messages. r=leftmostcat

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/0a321cb2cc86
Improve ICS parsing error messages. r=leftmostcat

Comment 3

[Magnus Melin [:mkmelin]]

Could take it on 115 later, but let's have it bake a bit. My main worry is that we would end up printing lots and lots of data in some cases and that would cause issues.

Comment 4

[Wayne Mery (:wsmwk)]

Comment on attachment 9357444 [details]
Bug 1857923 - Improve ICS parsing error messages. r=leftmostcat

[Triage Comment]
Approved for esr115

Comment 5

[Rob Lemley [:rjl]]

Thunderbird 115.4.2:
https://hg.mozilla.org/releases/comm-esr115/rev/96d6d973e361