1857946 - Preview state doesn't scroll with page

Status: VERIFIED FIXED

(Firefox :: Screenshots, defect, P1)

Description

[Niklas Baumgardner [:niklas]]

Attachment: screenshotsPreviewState.png

STR:

1. set screenshots.browser.component.enabled to true
2. open the new tab page or any scrolling page
3. open screenshots and scroll down

ER:
The preview state remains in the viewport

AR:
The preview state stays at the top of the page

Comment 1

[Niklas Baumgardner [:niklas]]

Attachment: Bug 1857946 - Use position sticky for screenshots preview container. r=sfoster

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b4a0f8afc02e
Use position sticky for screenshots preview container. r=sfoster,desktop-theme-reviewers,emilio

Comment 4

[Sandor Molnar[:smolnar]]

Backed out for causing bc failures at browser/components/screenshots/tests/browser/browser_screenshots_short_page_test.js

Backout link: https://hg.mozilla.org/integration/autoland/rev/d395554c2d37251bff17c82f44dd17198e70d6f3

Push with failures

Failure log -> TEST-UNEXPECTED-FAIL | browser/components/screenshots/tests/browser/browser_screenshots_short_page_test.js | The overlay spans the height of the window - 924 == 866

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/08bb959c7dca
Use position sticky for screenshots preview container. r=sfoster,desktop-theme-reviewers,emilio

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6aba5f06ad9f
Backed out changeset 08bb959c7dca for being partially backed out by merge back commit.
https://hg.mozilla.org/integration/autoland/rev/d940639e9c65
Use position sticky for screenshots preview container. r=sfoster,desktop-theme-reviewers,emilio

Comment 7

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/d940639e9c65

Comment 8

[Pulsebot]

Backout by ffxbld-merge:
https://hg.mozilla.org/releases/mozilla-beta/rev/37a06e1bc7b2
Backed out changeset b4a0f8afc02e for causing bc failures at browser/components/screenshots/tests/browser/browser_screenshots_short_page_test.js

Comment 9

[Alexandru Trif, Desktop Test Engineering [:atrif]]

Reproduced with Firefox 120.0a1 (2023-10-09) on Windows 10x64, by following steps from comment 0. The preview state stays at the top of the page when scrolling.
Verified fixed with Firefox 120.0b2 on Windows 10x64, macOS 12 and Ubuntu 18. The preview state remains in the viewport when scrolling.