1858048 - Don't include aria-label if we append the value as part of name computation (WPT accname/name/comp_embedded_control.html)

Status: RESOLVED FIXED

(Core :: Disability Access APIs, enhancement)

Description

[James Teh [:Jamie]]

Currently, in the case of an embedded control where we include the value in name computation, we include aria-label before the value, which violates the Acc Name spec. Fixing this will address these failing WPT tests.

Comment 1

[Nathan LaPré]

Attachment: Bug 1858048 - Part 1: Add FindAncestorIf utility to nsAccUtils, r?Jamie,eeejay,morgan

This revision adds a utility to find a non-generic ancestor of the given
accessible, provided it matches the given predicate.

Comment 2

[Nathan LaPré]

Attachment: Bug 1858048 - Part 1: Give listbox role eNameFromValueRule, r?Jamie

This revision is a small preparatory change to the name rule for the listbox
role. With this change, Gecko will look to the listbox value to determine its
name.

Depends on D204457

Comment 3

[Nathan LaPré]

Attachment: Bug 1858048 - Part 2: Improve embedded control name computation, r?Jamie

This revision changes Gecko's embedded control name computation to hew to the
relevant piece of the name computation spec (currently part "C" as of writing
this, labelled "Embedded Control"). To accomplish this, this revision moves the
call to AppendFromValue ahead of the call to Name. We use AppendFromValue to do
the embedded control computation, so it's appropriate to place it before we
check aria-label and similar. LocalAccessible::Value (and similar) contain the
necessary means to calculate the things we need, except for in the case of
listbox. So, this revision contains a carveout for listbox. Finally, this change
removes the previously-marked expected-failures from the relevant WPT meta file.

Depends on D204458

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9d3f1ecb27c9
Part 1: Give listbox role eNameFromValueRule, r=Jamie
https://hg.mozilla.org/integration/autoland/rev/334938a86d41
Part 2: Improve embedded control name computation, r=Jamie

Comment 5

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/9d3f1ecb27c9
https://hg.mozilla.org/mozilla-central/rev/334938a86d41