1858060 - Expose image role for <img alt="foo"> (WPT html-aam/roles.html el-img)

Status: RESOLVED WONTFIX

(Core :: Disability Access APIs, enhancement)

Description

[James Teh [:Jamie] (away returning 28 Jan)]

We currently expose role generic for an <img> with an alt but no src. The spec says we should expose role image regardless of the src. Fixing this will address the el-img failure in this WPT test.

Fixing this will be a bit interesting, since we probably shouldn't use ImageAccessible for something which doesn't have an image frame. We can probably use EnumRoleHyperTextAccessible<roles::GRAPHIC>. I guess we'll need to do that in HTMLMarkupMap, since the existing eImageType code path isn't relevant in this case. We should still check ShouldCreateImgAccessible though.

Comment 1

[Nathan LaPré]

It seems like the test to which you were referring when writing this issue is no longer failing on wpt.fyi, though it looks like that's just because the test is now gone from the test file. I can still try to make this change, I just want to note that it's not strictly contributing to Firefox's WPT score. Maybe there was some decision I missed in the intervening time?

Comment 2

[James Teh [:Jamie] (away returning 28 Jan)]

The test still exists, but it now has a valid src. See:
https://github.com/web-platform-tests/wpt/pull/43046#pullrequestreview-1723547917

Comment 3

[James Teh [:Jamie] (away returning 28 Jan)]

Durp, bumped control+enter.

We should perhaps get the spec clarified to say that an img with an invalid src isn't a valid image. Regardless, I don't think there's anything we need to do here.

Thanks for flagging.

Comment 4

[Nathan LaPré]

Thanks!