1858071 - Enable `editor.block_inline_check.use_computed_style` by default in all channels

Status: VERIFIED FIXED

(Core :: DOM: Editor, task, P3)

Description

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Unfortunately, the fix of bug 1840856 will cause new regression in the late beta builds and in the release channel in some tricky cases. (inserting line breaks vs. paragraphs.)

If we don't have any bug reports in 120 (i.e., in the 122 cycle of mozilla-central), we should enable the new behavior and minimizing the side-effect of bug 1840856.

Comment 1

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

I think that the new behavior is now enough stable.

Comment 2

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1858071 - Make `HTMLEditor` consider whether block or inline with CSS in the release channel r=m_kato!,#dom-core

The new behavior is better than the traditional behavior -- considering with
the default style of HTML -- especially when an element is an unknown element or
a custom element.

We've fixed a lot of assertion failures of this change and we have no serious
remaining issues now. Therefore, I think that we can ship it in all channels.

Comment 3

[Atila Butkovits]

The patch is working in today's beta-simulation: https://treeherder.mozilla.org/jobs?repo=try&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=ac04dff0a1be29186ef3650e459d8f9b2f4e1b8e

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1fb49a8e88c6
Make `HTMLEditor` consider whether block or inline with CSS in the release channel r=m_kato

Comment 5

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/1fb49a8e88c6

Comment 6

[Natalia Csoregi [:nataliaCs]]

Verified fixed in today's beta-sim

Comment 7

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Odd, I changed untouched fields with old values... Sorry for the spam.