1858106 - Consider increasing the number of atom tables.

Status: RESOLVED FIXED

(Core :: XPCOM, enhancement)

Description

[Emilio Cobos Álvarez (:emilio)]

Bug 1857828 comment 7 seems to be an improvement (though there are some perfherder issues, so I need to re-do some pushes and also see when it plateaus).

Comment 1

[Emilio Cobos Álvarez (:emilio)]

2x: https://treeherder.mozilla.org/perfherder/compare?originalProject=try&originalRevision=349f1a56ae802dc051f0973b13f63ee0e4fa11da&newProject=try&newRevision=cb896b44b0a780dd01b4b42a5e6af011613a9afb

4x: https://treeherder.mozilla.org/perfherder/compare?originalProject=try&originalRevision=349f1a56ae802dc051f0973b13f63ee0e4fa11da&newProject=try&newRevision=37e04cb034037664c1f21ff184af84c264457877

8x: https://treeherder.mozilla.org/perfherder/compare?originalProject=try&originalRevision=349f1a56ae802dc051f0973b13f63ee0e4fa11da&newProject=try&newRevision=91ddb7a5c751680bae24b13348cd3475fec5836d

Comment 2

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1858106 - Increase atom table count. r=smaug,#xpcom-reviewers

This gives a significant windows sp3 improvement, without negatively
affecting memory usage much (on a preallocated content process I get
0.13mb of atoms both with and without this patch).

We could consider bumping it further to 1024, though the relative
improvement vs. this patch is small.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/db89ae429b6e
Increase atom table count. r=smaug

Comment 4

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/db89ae429b6e